Skip to content

chore: fix C lint errors (issue #13417)#13422

Open
Ashutosh-1304 wants to merge 2 commits into
stdlib-js:developfrom
Ashutosh-1304:develop
Open

chore: fix C lint errors (issue #13417)#13422
Ashutosh-1304 wants to merge 2 commits into
stdlib-js:developfrom
Ashutosh-1304:develop

Conversation

@Ashutosh-1304

@Ashutosh-1304 Ashutosh-1304 commented Jul 11, 2026

Copy link
Copy Markdown

Resolves #13417

Description

What is the purpose of this pull request?

This pull request:

  • Updates the stdlib_ndarray_is_contiguous C function definition and declaration in the is-contiguous module to use const int64_t * for the shape and strides parameters. This resolves a C linting style error (constParameterPointer) reported during the automated lint workflow.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

  • Read, understood, and followed the [contributing guidelines][contributing].

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

@stdlib-js/reviewers

@Ashutosh-1304 Ashutosh-1304 requested a review from a team July 11, 2026 12:16
@stdlib-bot

Copy link
Copy Markdown
Contributor

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

Getting Started

Next Steps

  1. A project maintainer will approve GitHub Actions workflows for your PR.
  2. All CI checks must pass before your submission can be fully reviewed.
  3. You'll need to address any failures in linting or unit tests.

Running Tests Locally

You can use make to run any of the CI commands locally from the root directory of the stdlib repository:

# Run tests for all packages in the math namespace:
make test TESTS_FILTER=".*/@stdlib/math/.*"

# Run benchmarks for a specific package:
make benchmark BENCHMARKS_FILTER=".*/@stdlib/math/base/special/sin/.*"

If you haven't heard back from us within two weeks, please ping us by tagging the "reviewers" team in a comment on this PR.

If you have any further questions while waiting for a response, please join our Zulip community to chat with project maintainers and other community members.

We appreciate your contribution!

Documentation Links

@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Jul 11, 2026
Comment thread lib/node_modules/@stdlib/ndarray/base/assert/is-contiguous/src/main.c Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
ndarray/base/assert/is-contiguous $\\color{green}135/135$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}1/1$
$\\color{green}+100.00\\%$
$\\color{green}135/135$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

First-time Contributor A pull request from a contributor who has never previously committed to the project repository. Needs Review A pull request which needs code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix C lint errors

3 participants