Skip to content

feat: add blas/base/icamax#5068

Open
ShabiShett07 wants to merge 47 commits into
stdlib-js:developfrom
ShabiShett07:feature/icamax
Open

feat: add blas/base/icamax#5068
ShabiShett07 wants to merge 47 commits into
stdlib-js:developfrom
ShabiShett07:feature/icamax

Conversation

@ShabiShett07
Copy link
Copy Markdown
Contributor

@ShabiShett07 ShabiShett07 commented Feb 5, 2025 •
edited by aman-095
Loading

Progresses #2039

Description

What is the purpose of this pull request?

This pull request:

  • includes the support for Javascript and obtains Fortran reference from this page

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@stdlib-bot stdlib-bot added BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). First-time Contributor A pull request from a contributor who has never previously committed to the project repository. labels Feb 5, 2025
@stdlib-bot
Copy link
Copy Markdown
Contributor

stdlib-bot commented Feb 11, 2025 •
edited
Loading

Coverage Report

Package Statements Branches Functions Lines
blas/base/icamax $\color{green}231/231$
$\color{green}+0.00\%$ 		$\color{green}15/15$
$\color{green}+0.00\%$ 		$\color{green}2/2$
$\color{green}+0.00\%$ 		$\color{green}231/231$
$\color{green}+0.00\%$

The above coverage report was generated for the changes in this PR.

@ShabiShett07
Copy link
Copy Markdown
Contributor Author

ShabiShett07 commented Feb 11, 2025

/stdlib lint-autofix

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 11, 2025
@ShabiShett07 ShabiShett07 changed the title feat: add blas/base/icamax feat: add blas/base/icamax Feb 11, 2025
@ShabiShett07
Copy link
Copy Markdown
Contributor Author

ShabiShett07 commented Feb 11, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 11, 2025
@ShabiShett07 ShabiShett07 marked this pull request as ready for review February 11, 2025 18:32
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Feb 11, 2025
@ShabiShett07
Copy link
Copy Markdown
Contributor Author

ShabiShett07 commented Feb 11, 2025

@kgryte, Please do review this!

@stdlib-bot stdlib-bot removed the First-time Contributor A pull request from a contributor who has never previously committed to the project repository. label Feb 16, 2025
@aman-095
Copy link
Copy Markdown
Member

aman-095 commented Feb 19, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Feb 19, 2025
@aman-095
Copy link
Copy Markdown
Member

aman-095 commented Feb 19, 2025

/stdlib update-copyright-years

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Feb 19, 2025
@aman-095 aman-095 added the Feature Issue or pull request for adding a new feature. label Feb 19, 2025
@aman-095
Copy link
Copy Markdown
Member

aman-095 commented Feb 19, 2025

Use Progresses in the description, Resolves will automatically close the issue associated with #2039 once this PR gets merged.

@aman-095
Update package.json
aefb83a 
Check for the indentation and brackets. 

Signed-off-by: Aman Bhansali <92033532+aman-095@users.noreply.github.com>
@ShabiShett07
Copy link
Copy Markdown
Contributor Author

ShabiShett07 commented Feb 19, 2025

Use Progresses in the description, Resolves will automatically close the issue associated with #2039 once this PR gets merged.

Thank you Aman sir for making the necessary changes in this PR.

May I know is this PR ready for merge?

@aman-095
Update README.md
ea43236 
Signed-off-by: Aman Bhansali <92033532+aman-095@users.noreply.github.com>
aman-095
aman-095 requested changes Feb 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@aman-095 aman-095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update variable for index from icx to idx.

@aman-095 aman-095 removed the Needs Review A pull request which needs code review. label Feb 19, 2025
aman-095
aman-095 reviewed Feb 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@aman-095 aman-095 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this. Left an initial set of comments.

Comment thread lib/node_modules/@stdlib/blas/base/icamax/README.md Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/benchmark/benchmark.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/benchmark/benchmark.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/benchmark/benchmark.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/benchmark/benchmark.ndarray.js Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/docs/types/index.d.ts Outdated
Comment thread lib/node_modules/@stdlib/blas/base/icamax/lib/icamax.js
Comment thread lib/node_modules/@stdlib/blas/base/icamax/lib/index.js Outdated
@ShabiShett07
fix: resolved errors
ec7efeb 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: passed
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: passed
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: na
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@ShabiShett07
fix: resolved errors
61c28cf 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: na
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---

---
type: pre_push_report
description: Results of running various checks prior to pushing changes.
report:
  - task: run_javascript_examples
    status: passed
  - task: run_c_examples
    status: na
  - task: run_cpp_examples
    status: na
  - task: run_javascript_readme_examples
    status: passed
  - task: run_c_benchmarks
    status: na
  - task: run_cpp_benchmarks
    status: na
  - task: run_fortran_benchmarks
    status: na
  - task: run_javascript_benchmarks
    status: passed
  - task: run_julia_benchmarks
    status: na
  - task: run_python_benchmarks
    status: na
  - task: run_r_benchmarks
    status: na
  - task: run_javascript_tests
    status: na
---
@kgryte
fix: address parentheses
be9ffd8 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Sep 2, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Sep 2, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Sep 2, 2025
kgryte
kgryte reviewed Sep 2, 2025
View reviewed changes
Comment thread lib/node_modules/@stdlib/blas/base/icamax/lib/index.js Outdated
@kgryte
docs: fix constructor name
7dff8e1 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte kgryte self-requested a review November 19, 2025 05:38
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Nov 19, 2025

/stdlib merge

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Nov 19, 2025
@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Nov 19, 2025
@DhruvArvindSingh DhruvArvindSingh mentioned this pull request Mar 14, 2026
Open
7 tasks
@MeKaustubh07 MeKaustubh07 requested a review from a team June 1, 2026 05:40
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jun 1, 2026

/stdlib update-copyright-years

@stdlib-bot stdlib-bot added the bot: In Progress Pull request is currently awaiting automation. label Jun 1, 2026
@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jun 1, 2026

@MeKaustubh07 Would you mind doing a review of this, if you haven't already?

@stdlib-bot stdlib-bot removed the bot: In Progress Pull request is currently awaiting automation. label Jun 1, 2026
@MeKaustubh07
Copy link
Copy Markdown
Member

MeKaustubh07 commented Jun 1, 2026

@MeKaustubh07 Would you mind doing a review of this, if you haven't already?

@kgryte I'm currently working through it locally. The review request notifications are being triggered automatically whenever I push trial commits while working on someone else's branch, so sorry about the noise.

I'll make sure to explicitly mention you when I've finished reviewing and the PR is ready for your attention.

@kgryte
Copy link
Copy Markdown
Member

kgryte commented Jun 1, 2026 •
edited
Loading

@MeKaustubh07 Sounds good. Obviously I just merged in the latest and updated the copyright years, so you'll want to sync your local copy with the current remote.

@MeKaustubh07
docs: fix variable naming and description
5484643 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: passed
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07
refactor: example acc to scasum
46489a9 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07
chore: format and use correct type
c8c3e7f 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07
fix: remove unwanted spaces in test
a67c8dc 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: na
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: na
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: passed
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07
chore: cleanup
c4d8ffe 
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown_pkg_readmes
    status: passed
  - task: lint_markdown_docs
    status: na
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: passed
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: passed
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
@MeKaustubh07
Copy link
Copy Markdown
Member

MeKaustubh07 commented Jun 1, 2026

@kgryte ready for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aman-095 aman-095 Awaiting requested review from aman-095

@kgryte kgryte Awaiting requested review from kgryte

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). Feature Issue or pull request for adding a new feature. Needs Review A pull request which needs code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShabiShett07 @stdlib-bot @aman-095 @kgryte @MeKaustubh07