feat: add `stats/incr/nanminabs` by rahulrangers · Pull Request #5637 · stdlib-js/stdlib

rahulrangers · 2025-03-01T18:49:11Z

Resolves #5552

Description

What is the purpose of this pull request?

This PR adds the package stats/incr/nanminabs which is a wrapper around stats/incr/minabs to handle NaN values

Related Issues

Does this pull request have any related issues?

This pull request:

Resolves [RFC]: add stats/incr/nanminabs #5552

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

Read, understood, and followed the contributing guidelines.

@stdlib-js/reviewers

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: passed - task: lint_repl_help status: passed - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed ---

stdlib-bot · 2025-03-01T18:50:45Z

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/incr/nanminabs	$\color{green}134/134$ $\color{green}+100.00\%$	$\color{green}7/7$ $\color{green}+100.00\%$	$\color{green}2/2$ $\color{green}+100.00\%$	$\color{green}134/134$ $\color{green}+100.00\%$

The above coverage report was generated for the changes in this PR.

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: passed - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: passed - task: lint_javascript_cli status: na - task: lint_javascript_examples status: passed - task: lint_javascript_tests status: passed - task: lint_javascript_benchmarks status: passed - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: passed - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: passed - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: passed - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: passed - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed --- --- type: pre_push_report description: Results of running various checks prior to pushing changes. report: - task: run_javascript_examples status: na - task: run_c_examples status: na - task: run_cpp_examples status: na - task: run_javascript_readme_examples status: na - task: run_c_benchmarks status: na - task: run_cpp_benchmarks status: na - task: run_fortran_benchmarks status: na - task: run_javascript_benchmarks status: na - task: run_julia_benchmarks status: na - task: run_python_benchmarks status: na - task: run_r_benchmarks status: na - task: run_javascript_tests status: na ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: passed - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: na - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

--- type: pre_commit_static_analysis_report description: Results of running static analysis checks when committing changes. report: - task: lint_filenames status: passed - task: lint_editorconfig status: passed - task: lint_markdown status: na - task: lint_package_json status: na - task: lint_repl_help status: na - task: lint_javascript_src status: na - task: lint_javascript_cli status: na - task: lint_javascript_examples status: na - task: lint_javascript_tests status: na - task: lint_javascript_benchmarks status: na - task: lint_python status: na - task: lint_r status: na - task: lint_c_src status: na - task: lint_c_examples status: na - task: lint_c_benchmarks status: na - task: lint_c_tests_fixtures status: na - task: lint_shell status: na - task: lint_typescript_declarations status: passed - task: lint_typescript_tests status: na - task: lint_license_headers status: passed ---

rahulrangers · 2025-03-02T08:48:31Z

can you please review @kgryte

Planeshifter

Sorry for not getting to this for so long... thanks for your PR!

Planeshifter · 2026-03-10T00:40:39Z

@@ -0,0 +1,69 @@
+{
+  "name": "@stdlib/stats/incr/minabs",


Wrong package name — this is nanminabs, not minabs.

Suggested change

"name": "@stdlib/stats/incr/minabs",

"name": "@stdlib/stats/incr/nanminabs",

Planeshifter · 2026-03-10T00:40:40Z

+{
+  "name": "@stdlib/stats/incr/minabs",
+  "version": "0.0.0",
+  "description": "Compute a minimum absolute value incrementally.",


Missing "ignoring NaN values" in the description.

Suggested change

"description": "Compute a minimum absolute value incrementally.",

"description": "Compute a minimum absolute value incrementally, ignoring NaN values.",

Planeshifter · 2026-03-10T00:40:43Z

+		v = ( randu() * 100.0 ) - 50.0;
+	}
+	min = accumulator( v );
+	console.log( '%d\t%d', v.toFixed( 3 ), ( min === null ) ? NaN : min.toFixed( 3 ) );


.toFixed() returns a string, so %d will strip trailing zeros. Use %s.

Suggested change

console.log( '%d\t%d', v.toFixed( 3 ), ( min === null ) ? NaN : min.toFixed( 3 ) );

console.log( '%s\t%s', ( v !== v ) ? 'NaN' : v.toFixed( 3 ), ( min === null ) ? 'null' : min.toFixed( 3 ) );

Planeshifter · 2026-07-07T03:51:08Z

Closing in favor of #12246, which is a revised version of this PR that already addresses the review feedback here (correct package.json name, updated description, and fixed example format string). Thanks for the contribution, @rahulrangers — the work lives on in #12246.

stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. Good First PR A pull request resolving a Good First Issue. labels Mar 1, 2025

rahulrangers and others added 5 commits March 2, 2025 01:17

Merge branch 'stdlib-js:develop' into nanminabs

787b52a

Planeshifter changed the title ~~feat: add @stdlib/stats/incr/nanminabs~~ feat: add stats/incr/nanminabs Jan 14, 2026

Planeshifter requested changes Mar 10, 2026

View reviewed changes

Planeshifter added Needs Changes Pull request which needs changes before being merged. and removed Needs Review A pull request which needs code review. labels Mar 10, 2026

faisalaffan mentioned this pull request May 22, 2026

feat: add stats/incr/nanminabs #12246

Open

5 tasks

stdlib-bot added the Potential Duplicate There might be another pull request resolving the same issue. label May 23, 2026

Planeshifter closed this Jul 7, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat: add `stats/incr/nanminabs`#5637

feat: add `stats/incr/nanminabs`#5637
rahulrangers wants to merge 6 commits into
stdlib-js:developfrom
rahulrangers:nanminabs

rahulrangers commented Mar 1, 2025

Uh oh!

stdlib-bot commented Mar 1, 2025 •

edited

Loading

Uh oh!

rahulrangers commented Mar 2, 2025 •

edited

Loading

Uh oh!

Planeshifter left a comment

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter Mar 10, 2026

Uh oh!

Planeshifter commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	"name": "@stdlib/stats/incr/minabs",
	"name": "@stdlib/stats/incr/nanminabs",

	"description": "Compute a minimum absolute value incrementally.",
	"description": "Compute a minimum absolute value incrementally, ignoring NaN values.",

	console.log( '%d\t%d', v.toFixed( 3 ), ( min === null ) ? NaN : min.toFixed( 3 ) );
	console.log( '%s\t%s', ( v !== v ) ? 'NaN' : v.toFixed( 3 ), ( min === null ) ? 'null' : min.toFixed( 3 ) );

Uh oh!

Uh oh!

Conversation

rahulrangers commented Mar 1, 2025

Description

Related Issues

Questions

Other

Checklist

Uh oh!

stdlib-bot commented Mar 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage Report

Uh oh!

rahulrangers commented Mar 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Planeshifter left a comment

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Planeshifter commented Jul 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

stdlib-bot commented Mar 1, 2025 •

edited

Loading

rahulrangers commented Mar 2, 2025 •

edited

Loading