fix: override esbuild to >=0.28.1 to resolve security advisories#1
Merged
Merged
Conversation
The drizzle-kit dev toolchain pulled in esbuild@0.18.20 (via the deprecated @esbuild-kit/* chain), flagged by GHSA-67mh-4wv8-2f99. Force esbuild up to a patched release, which also clears the newer arbitrary-file-read and binary-integrity advisories (GHSA-g7r4-m6w7-qqqr, GHSA-36qx-fr4f-26g5). Move overrides to pnpm-workspace.yaml since pnpm v11 no longer reads the "pnpm.overrides" field in package.json (the existing @types/react overrides were being silently ignored). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the
esbuildsecurity advisories flagged bypnpm audit. The vulnerableesbuild@0.18.20was pulled in only through the dev toolchain (drizzle-kit → @esbuild-kit/esm-loader → @esbuild-kit/core-utils → esbuild), so this affects local development only — not the production/Docker build.Inspired by upstream PR leonvanzyl/agentic-coding-starter-kit#1, but raised the floor further to also clear newer advisories.
Changes
esbuild: ">=0.28.1"override.pnpm-workspace.yaml— pnpm v11 no longer reads thepnpm.overridesfield inpackage.json, so the existing@types/react/@types/react-domoverrides were being silently ignored. They now actually take effect (resolved versions are unchanged: 19.2.5 / 19.2.3).pnpm-lock.yaml.Advisories resolved
<=0.24.2>=0.27.3 <0.28.1>=0.17.0 <0.28.1After the change only a single
esbuild@0.28.1remains andpnpm auditreports no esbuild advisories.Verification
pnpm audit— no esbuild advisories remain (high 10→9, low 5→4)pnpm exec tsx— TypeScript transpiles/runs via esbuild 0.28.1pnpm exec drizzle-kit check— config loads, "Everything's fine"pnpm lint— cleanpnpm build— compiles + TypeScript pass (full build verified with env vars set)🤖 Generated with Claude Code