fix(ci): align pnpm 11 and Node 22 so CI and Docker builds pass#5
Merged
Conversation
CI pinned pnpm 9 (pnpm/action-setup version: 9), but the project keeps its settings (allowBuilds, overrides) in pnpm-workspace.yaml — a pnpm 10+/11 feature. pnpm 9 treats that file as a workspace definition and aborts with "packages field missing or empty", so every job died at "Setup Node.js". pnpm 11 in turn requires Node 22.13+, while the project still targeted Node 20. Align everything on pnpm 11 + Node 22: - package.json: add "packageManager": "pnpm@11.6.0". - ci.yml: drop the hard-coded `version: 9`; pnpm/action-setup reads the version from packageManager. Node comes from .nvmrc (now 22), so jobs follow suit. - .nvmrc: 20 -> 22. - Dockerfile: base image node:20 -> node:22-alpine; install pnpm via `corepack enable` (honours packageManager) instead of `pnpm@9`; also copy pnpm-workspace.yaml into the deps stage so the build-script allowlist and overrides apply during `pnpm install`. - README: note Node 22+ requirement. Verified: `podman build` produces a working image (HTTP 200 boot test); `pnpm install --frozen-lockfile` and `pnpm lint` pass locally. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
be67e68 to
bdcf617
Compare
stefanowitschdev
added a commit
that referenced
this pull request
Jun 13, 2026
Re-run `pnpm sync-template` so create-agentic-app/template/ picks up the pnpm 11 + Node 22 changes from #5: packageManager field, .nvmrc 22, and the Dockerfile (node:22-alpine + corepack, pnpm-workspace.yaml in the deps stage). Co-authored-by: stefan.kunz <stefan.kunz@adbsafegate.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every CI run failed within ~15–20s at the Setup Node.js step, before any lint/build/test:
Root cause: pnpm/Node version drift. CI pinned pnpm 9, but the project keeps its settings (
allowBuilds,overrides) inpnpm-workspace.yaml(a pnpm 10+/11 feature). pnpm 9 treats that file as a workspace definition, requires apackages:field, and aborts. In turn, pnpm 11 requires Node 22.13+, while the project still targeted Node 20 (.nvmrc,Dockerfile, README) — so simply pinning pnpm 11 madepnpmcrash under Node 20 (ERR_UNKNOWN_BUILTIN_MODULE). The same pnpm 9 / Node 20 mismatch also affected the Docker build.Fix — align on pnpm 11 + Node 22
package.json— add"packageManager": "pnpm@11.6.0"..github/workflows/ci.yml— drop the hard-codedversion: 9;pnpm/action-setupreads the version frompackageManager. Node comes from.nvmrc..nvmrc—20→22.Dockerfile— basenode:20-alpine→node:22-alpine; install pnpm viacorepack enable(honourspackageManager) instead ofpnpm@9; copypnpm-workspace.yamlinto the deps stage so the build-script allowlist (allowBuilds) and overrides apply duringpnpm install.README— note the Node 22+ requirement.Verification
podman buildproduces a working image — boot test returns HTTP 200.pnpm install --frozen-lockfileandpnpm lintpass locally.🤖 Generated with Claude Code