Cleanup and modernize mockrunner-servlet unit tests#11
Closed
steinarb wants to merge 46 commits into
Closed
Conversation
This upgrade fixes warnings in IntelliJ IDEA about the CVE-2021-33813 in the JDOM 1.0 dependency. The <relativePath> tags are redundant and cause issues in IntelliJ IDEA. It is also better to use JAVA_HOME instead of /usr/bin as javadoc may not always be symlinked to a Java 8 JDK causing compilation issues. Signed-off-by: Wouter Born <github@maindrain.net>
… and as compile scope dependency to mockrunner-all
… and explicityl add newest cgi-nodeps dependency
…lugin config of mockrunner-ejb
…b repo mockrunner/mockrunner" This reverts commit 118065a.
Use version 1.9.4 of commons-beanutils
…ervlet/javax.servlet-api/4.0.1
…ivate to public to match interface ServletRequest
…ting Java code in mockrunner-servlet
Leaving the saving of surefire logs and crash logs in place. Also leaving the check for OOM kills in place.
Upgrade javax servlet fixes #90
…ner parent pom dependency management
…ng to editorconfig
…en module mockrunner-servlet
…aven module mockrunnner-servlet
…ter with assertj for collection assertions Also suppress warnings about the use of raw types (i.e. non-parameterized types) in the tests.
…t 4 to JUnit jupiter
cemartins
reviewed
May 25, 2026
Contributor
cemartins
left a comment
There was a problem hiding this comment.
Glad that you're taking this on!
Changes look good to me.
Owner
Author
|
Hi this was the wrong PR. I didn't pay attention and made a PR against my mockrunner repo which is sort of useless, so I closed this one and made a new one in the right repo. Ie. mockrunner#93 that I see you've also looked at. Sorry about that! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@cemartins Could you take a look at this, please?
The changes are:
(this is sort of a preparation to fixing issue 69. I needed unit tests for that, and the existing unit tests of mockrunner-servlet were... weird...)