Skip to content

Order the error tests like the functions they test #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stepchowfun merged 1 commit into from
Oct 11, 2026
Merged

Order the error tests like the functions they test #598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
112 changes: 56 additions & 56 deletions src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,62 @@ mod tests {
);
}

#[test]
fn format_errors_empty() {
assert_eq!(format_errors(&[]), "");
}

#[test]
fn format_errors_single() {
assert_eq!(
format_errors(&[Error::new("Something went wrong.", None, None, None)]),
"[Error] Something went wrong.",
);
}

#[test]
fn format_errors_double() {
assert_eq!(
format_errors(&[
Error::new("Something went kinda wrong.", None, None, None),
Error::new("Something went sorta wrong.", None, None, None),
Error::new("Something went very wrong.", None, None, None),
]),
"\
[Error] Something went kinda wrong.

[Error] Something went sorta wrong.

[Error] Something went very wrong.\
",
);
}

#[test]
fn format_errors_visually_empty_line() {
assert_eq!(
format_errors(&[
Error::new(
"1 \u{2502} foo\n \u{250a} \u{203e}\u{203e}\u{203e}\n2 \u{2502} \
bar\n \u{250a} \u{203e}\u{203e}\u{203e}\n3 \u{2502} baz\n \
\u{250a} \u{203e}\u{203e}\u{203e}\n4 \u{2502} qux\n \u{203e}\
\u{203e}\u{203e}",
None,
None,
None,
),
Error::new("Something went sorta wrong.", None, None, None),
]),
"\
[Error] 1 \u{2502} foo\n \u{250a} \u{203e}\u{203e}\u{203e}\n2 \u{2502} \
bar\n \u{250a} \u{203e}\u{203e}\u{203e}\n3 \u{2502} baz\n \
\u{250a} \u{203e}\u{203e}\u{203e}\n4 \u{2502} qux\n \u{203e}\
\u{203e}\u{203e}
[Error] Something went sorta wrong.\
",
);
}

#[test]
fn listing_empty() {
let source = "";
Expand Down Expand Up @@ -538,60 +594,4 @@ mod tests {
"1 \u{2502} foo\n \u{250a} \u{203e}\u{203e}\u{203e}\n2 \u{2502} bar",
);
}

#[test]
fn format_errors_empty() {
assert_eq!(format_errors(&[]), "");
}

#[test]
fn format_errors_single() {
assert_eq!(
format_errors(&[Error::new("Something went wrong.", None, None, None)]),
"[Error] Something went wrong.",
);
}

#[test]
fn format_errors_double() {
assert_eq!(
format_errors(&[
Error::new("Something went kinda wrong.", None, None, None),
Error::new("Something went sorta wrong.", None, None, None),
Error::new("Something went very wrong.", None, None, None),
]),
"\
[Error] Something went kinda wrong.

[Error] Something went sorta wrong.

[Error] Something went very wrong.\
",
);
}

#[test]
fn format_errors_visually_empty_line() {
assert_eq!(
format_errors(&[
Error::new(
"1 \u{2502} foo\n \u{250a} \u{203e}\u{203e}\u{203e}\n2 \u{2502} \
bar\n \u{250a} \u{203e}\u{203e}\u{203e}\n3 \u{2502} baz\n \
\u{250a} \u{203e}\u{203e}\u{203e}\n4 \u{2502} qux\n \u{203e}\
\u{203e}\u{203e}",
None,
None,
None,
),
Error::new("Something went sorta wrong.", None, None, None),
]),
"\
[Error] 1 \u{2502} foo\n \u{250a} \u{203e}\u{203e}\u{203e}\n2 \u{2502} \
bar\n \u{250a} \u{203e}\u{203e}\u{203e}\n3 \u{2502} baz\n \
\u{250a} \u{203e}\u{203e}\u{203e}\n4 \u{2502} qux\n \u{203e}\
\u{203e}\u{203e}
[Error] Something went sorta wrong.\
",
);
}
}
Loading