test: establish baseline coverage#11
Open
sigilmakes wants to merge 3 commits into
Open
Conversation
11 tasks
15212c0 to
a1f79d2
Compare
77 tasks
10 tasks
Replace local_data-dependent UPF parser tests with synthetic fixtures. Add baseline coverage for CLI main, structure file loading, structure analysis flags, ML inference error paths, and k-mesh invariants. Refs #10
Use period-five-and-heavier elements for the heavy-element heuristic. Make k-spacing tests assert the VASP-style reciprocal lattice convention instead of only mirroring current numeric outputs.
a1f79d2 to
f535fcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds portable baseline coverage before the Core pipeline refactor.
Why
The staged Core pipeline refactor needs a reliable behavioural safety net first. The current tests still depended on private
local_data/pseudopotential files and did not cover several public/error paths. This PR freezes current behaviour with portable synthetic fixtures and tightens the physics assumptions around k-spacing and heavy-element detection.Closes #10.
How to test
Current local result:
Changes
local_data/UPF parser tests with synthetic portable UPF fixtures.main()coverage without shelling out or loading a real model.KSPACING/ solid-state reciprocal-lattice convention.2πreciprocal-lattice convention.Z >= 57to period 5 and heavier for SOC consideration.Notes
This is a stacked draft PR based on
docs/agents-mdwhile #7 is still open. After #7 merges, this branch should be rebased ontomainand the PR base updated tomainbefore review/merge.Written by an agent on behalf of Willow.