Repository navigation
Make CommandObject readonly, validate cache_control and require swagger-php - #61
Merged
Merged
Conversation
…er-php CommandObject's controller defaults to null instead of the internal CommandController, cache_control accepts only a string or null, and the swagger-php attributes the commands use are a direct dependency.
…mple The route's controller can be Class::method or a service id, as with the x vendor extension. Single backslashes keep the docs example valid PHP.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 8 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…eadonly # Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tightens three parts of the public surface before it is frozen.
CommandObjectisfinal readonly, and itscontrollerdefaults tonullinstead of the bundle's internalCommandController. A command without a controller is still routed toCommandController; the attribute's docblock describes whatclassandcontrollerdo on a parameter and on a command class.cache_controlaccepts only a string ornull, with aninfo()text.falseused to be accepted and behaved likenull.zircote/swagger-php, whose attributes describe the commands, is required directly, with the same range NelmioApiDocBundle allows.docs/command-routing.mduses single backslashes, so it is valid PHP.The changelog's Upgrading section covers reading a
nullcontroller and replacingcache_control: false.