Repository navigation
Raise the minimums that fail and test the lowest dependencies in CI - #62
Merged
Merged
Conversation
Nelmio's generator is resettable from 5.11.1, which debug regeneration needs, and property-info 6.4 fails alongside phpdoc-parser 2. A CI job runs the tests against the lowest allowed versions.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 2 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI only installed the newest versions in each Composer range, so the lower bounds were never run. Installing the lowest allowed versions found two that do not work:
nelmio/api-doc-bundlebelow 5.11.1 has no resettableApiDocGenerator, so a long-running debug worker keeps validating against the OpenAPI document it generated first. The minimum is now 5.11.1.symfony/property-info6.4.0, which Nelmio allows, constructsphpstan/phpdoc-parser1.x classes while swagger-php requires phpdoc-parser 2, so every API request fails.symfony/property-info: ^7.4 || ^8.0is now required directly, like the other Symfony components.The test logger fixture no longer types its parameters, so it is compatible with
psr/log1, 2 and 3.A new CI job runs the tests on PHP 8.4 with
--prefer-lowest. It runs tests only: static analysis on the oldest tooling reports only noise from old PHPStan extensions.