Conversation
in addition to `yaml`
moves some logging out of `INFO` (stderr from tracing crate) and into plain STDOUT
peterhuene
left a comment
There was a problem hiding this comment.
This looks like a great first step towards the test command.
I have a few feedback comments and at least one "discussion" comment regarding the UX of the feature that we can easily punt to later if desired.
|
@peterhuene I believe that I've "rustified" this sufficiently. We are yielding iterators, avoiding redundant I've also gone ahead and added some simple tagging and filtering of tests ( Lastly, I've made another change to where tests are looked for. In addition to test YAML being looked for at "sibling" locations (e.g. Test files still have to have the same basename as the WDL they are testing. I believe the above addresses all the received feedback 🎉 thanks for the review! LMK if there are any other changes we want to get in this PR |
peterhuene
left a comment
There was a problem hiding this comment.
Looks great, just two nit comments!
Describe the problem or feature in addition to a link to the issues.
As the
wdl-engineinterface is currently undergoing a refactor, this PR does not interact withwdl-engineat all. This PR simply defines the YAML which will be used for defining unit tests and does some basic parsing and logging as proof of concept.stjude-rust-labs/rfcs#1
Before submitting this PR, please make sure:
For external contributors:
For all contributors:
nextbranch in the sprocket.bio repository [if you are a Sprocket team member] or (b) have suggested any changes you think need to be made to sprocket.bio in the description of your PR [if you are an external contributor].For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.