Skip to content

[FEATURE] Global JSONParserConfiguration support#1050

Draft
venkat-cheenu wants to merge 1 commit intostleary:masterfrom
venkat-cheenu:feature_jsonparser_global_configuration_support
Draft

[FEATURE] Global JSONParserConfiguration support#1050
venkat-cheenu wants to merge 1 commit intostleary:masterfrom
venkat-cheenu:feature_jsonparser_global_configuration_support

Conversation

@venkat-cheenu
Copy link
Copy Markdown

No description provided.

@venkat-cheenu venkat-cheenu force-pushed the feature_jsonparser_global_configuration_support branch from 817811f to cf05e39 Compare April 5, 2026 03:55
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 5, 2026

@stleary
Copy link
Copy Markdown
Owner

stleary commented Apr 6, 2026

The Java6 compiler error should be easy to fix, I think you just need to use this statement:

  private static final AtomicReference<JSONParserConfiguration> GLOBAL_CONFIG  = 
        new AtomicReference<JSONParserConfiguration>(null);

AtomicReference may not be a good idea. This lib is not thread-safe, per design. Adding it here may give the impression the project is moving in that direction, which it is not.

There are no unit tests for the new/changed code.

If some maps need to be parsed with keep-null, and some maps without it, how would you get that behavior?

I'm not convinced yet that this is the best approach. It may be that this problem should be fixed in user code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants