[FEATURE] Global JSONParserConfiguration support#1050
Draft
venkat-cheenu wants to merge 1 commit intostleary:masterfrom
Draft
[FEATURE] Global JSONParserConfiguration support#1050venkat-cheenu wants to merge 1 commit intostleary:masterfrom
venkat-cheenu wants to merge 1 commit intostleary:masterfrom
Conversation
817811f to
cf05e39
Compare
|
Owner
|
The Java6 compiler error should be easy to fix, I think you just need to use this statement: AtomicReference may not be a good idea. This lib is not thread-safe, per design. Adding it here may give the impression the project is moving in that direction, which it is not. There are no unit tests for the new/changed code. If some maps need to be parsed with keep-null, and some maps without it, how would you get that behavior? I'm not convinced yet that this is the best approach. It may be that this problem should be fixed in user code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



No description provided.