exclude fpu options from stm32wl55#1474
Merged
fpistm merged 1 commit intostm32duino:masterfrom Aug 16, 2021
Merged
Conversation
Member
|
Please @valeros could you review this? |
valeros
suggested changes
Aug 16, 2021
Contributor
|
Hi @dolfandringa ! Many thanks for the PR. Please review my comments above. |
481d215 to
a3673c9
Compare
a3673c9 to
11bcd30
Compare
Contributor
Author
|
With this PR, and the one I am submitting for platformio, I got a basic blink sketch to compile, upload and (gdb) debug correctly on the nucleo stm32wl55JC1. |
Contributor
|
LGTM. |
Member
|
Thank you @valeros and @dolfandringa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes bug
Arduino Core STM32 provides a platformio-build.py file that sets compiler build flags for Arduino Core STM32 in platformio. This file sets the -mfpu flag automatically for every cortex-m4 MCU. But according to the CMSIS drivers, the STM32WL55 does not contain an FPU, causing this python script to set the wrong compile time flags. The proposed PR fixes this by excluding the -mfpu option from the CPPDEFINES flags.
Validation
The following sketch won't compile without it, but will with this fix:
Closing issues
Fixes #1473