Skip to content

fix(website): rewind landing editor scroll when a scene renders #189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zantvoort merged 1 commit into from
Jul 6, 2026
Merged

fix(website): rewind landing editor scroll when a scene renders #189

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion website/src/pages/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,7 +420,7 @@ export default function Home() {
const editorEl=document.querySelector('.storm-home .editor'), sqlBtn=document.getElementById('sqlbtn'),
sqlBtnText=document.getElementById('sqlbtntext'), sqlPanel=document.getElementById('sqlpanel');
let showSql=false, curIdx=0;
function renderSql(){ sqlPanel.innerHTML=SQL[curIdx]||'<span class="sqlc">-- no query</span>'; }
function renderSql(){ sqlPanel.innerHTML=SQL[curIdx]||'<span class="sqlc">-- no query</span>'; sqlPanel.scrollLeft=0; }
function onSqlClick(){
showSql=!showSql;
editorEl.classList.toggle('show-sql',showSql);
Expand Down Expand Up @@ -504,6 +504,13 @@ export default function Home() {

const text=fullText(sc.code);
setGutter(text);
// Rewind the horizontal scroller before typing. Desktop resets it for
// free (the near-empty first render collapses scrollWidth, clamping
// scrollLeft to 0), but iOS Safari keeps the stale offset when content
// shrinks — so one touch pan (even an accidental diagonal swipe while
// scrolling the page) would leave every later scene with the start of
// each line cut off.
codeEl.scrollLeft=0;

if(reduce){
codeEl.innerHTML=render(sc.code,text.length,false);
Expand All @@ -524,6 +531,7 @@ export default function Home() {
}
if(myGen!==gen) return;
codeEl.innerHTML=render(sc.code,text.length,false);
codeEl.scrollLeft=0; // settle the finished snippet at its line starts
await wait(fast?160:360);
if(myGen!==gen) return;
statusTextEl.textContent=sc.caption;statusEl.classList.add('show');
Expand Down
Loading