fix(website): limit Storm-column gradient to the comparison matrix#195
Merged
Conversation
The brand gradient on column 2 was applied via .storm-tut .cmp, which is shared by every comparison table, so it also tinted the tutorial tables. Scope the gradient to a .cmp-brand modifier used only on the /comparison decision matrix; tutorial .cmp tables keep column 2 unstyled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The brand gradient on the Storm column (column 2) was styled via
.storm-tut .cmp thead th:nth-child(2)/.storm-tut .cmp tbody tr td:nth-child(2). Since both the/comparisondecision matrix and every tutorial comparison table share the.cmpclass inside.storm-tut, the gradient also leaked into the tutorial tables.Change
tutorialTheme.js: the two gradient rules now target a.cmp-brandmodifier instead of.cmp, so plain.cmptables keep column 2 unstyled (same treatment as the other columns).comparison.js: the decision matrix is now<table class="cmp cmp-brand">, so it remains the only place with the gradient.Effect
/comparisonmatrix: gradient unchanged./tutorials/transactions,/tutorials/n-plus-one,/tutorials/projections): Storm column is now plain, no gradient. They keep the framed card, striping, and header styling from.cmp.