feat(a2a): add agent_card_url property to A2AServer for customizable url in AgentCard#2003
Open
waitasecant wants to merge 1 commit intostrands-agents:mainfrom
Open
feat(a2a): add agent_card_url property to A2AServer for customizable url in AgentCard#2003waitasecant wants to merge 1 commit intostrands-agents:mainfrom
agent_card_url property to A2AServer for customizable url in AgentCard#2003waitasecant wants to merge 1 commit intostrands-agents:mainfrom
Conversation
…ble `url` in `AgentCard`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A2AServercurrently sets theurlfield in theAgentCardtohttp_url, which always appends a trailing slash. In load-balanced or reverse-proxy deployments, the advertised URL may need to differ from the internalhttp_url- for example, to omit the trailing slash or use a completely different base URL.This PR adds an
agent_card_urlproperty toA2AServerthat defaults tohttp_urlbut can be overridden via a setter, giving users control over the URL advertised in theAgentCard.Related Issues
No related issues.
Documentation PR
To be created after approval
Type of Change
New feature
Testing
Yes, I have tested the change and verified it doesn't break functionality.
hatch run prepareChecklist
Use Cases
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.