Issue stratisd 3597

.packit.yaml

@@ -27,7 +27,6 @@ jobs:
   - job: copr_build
     trigger: pull_request
     identifier: copr_pull
-    manual_trigger: true
     targets:
       - fedora-all
 

docs/stratis.txt

@@ -117,6 +117,34 @@ pool unbind <(clevis|keyring)> <pool name> [--token-slot <token slot>]::
      mechanism. MOVE NOTICE: The "unbind" subcommand can also be found under
      the "pool encryption" subcommand. The "pool unbind" subcommand that you
      are using now is deprecated and will be removed in stratis 3.10.0.
+pool encryption on --in-place <(--uuid <uuid> |--name <name>)> [--key-desc <key_desc>] [--clevis <(nbde|tang|tpm2)> [--tang-url <tang_url>] [<(--thumbprint <thp> | --trust-url)>]::
+     Turn encryption on for the specified pool. This operation takes time
+     proportional to the size of the pool.
+pool encryption off --in-place <(--uuid <uuid> |--name <name>)>::
+     Turn encryption off for the specified pool. This operation takes time
+     proportional to the size of the pool.
+pool encryption reencrypt --in-place <(--uuid <uuid> |--name <name>)>::
+     Reencrypt the pool with a new master key. This operation takes time
+     proportional to the size of the pool.
+pool encryption bind <(nbde|tang)> <(--uuid <uuid> |--name <name>)> <(--thumbprint <thp> | --trust-url)> <url>::
+     Bind the devices in the specified pool to a supplementary encryption
+     mechanism that uses NBDE (Network-Bound Disc Encryption). *tang* is
+     an alias for *nbde*.
+pool encryption bind tpm2 <(--uuid <uuid> |--name <name>)>::
+     Bind the devices in the specified pool to a supplementary encryption
+     mechanism that uses TPM 2.0 (Trusted Platform Module).
+pool encryption bind keyring <(--uuid <uuid> |--name <name>)> <keydesc>::
+     Bind the devices in the specified pool to a supplementary encryption
+     mechanism using a key in the kernel keyring.
+pool encryption rebind clevis <(--uuid <uuid> |--name <name>)> [--token-slot <token slot>]::
+     Rebind the devices in the specified pool using the Clevis configuration
+     with which the devices in the pool were previously bound.
+pool encryption rebind keyring <(--uuid <uuid> |--name <name>)> <keydesc> [--token-slot <token slot>]::
+     Rebind the devices in the specified pool using the specified key
+     description.
+pool encryption unbind <(clevis|keyring)> <(--uuid <uuid> |--name <name>)> [--token-slot <token slot>]::
+     Unbind the devices in the specified pool from the specified encryption
+     mechanism.
 pool set-fs-limit <pool name> <amount> ::
      Set the limit on the number of file systems allowed per-pool. This number
      may only be increased from its current value.
@@ -243,6 +271,20 @@ OPTIONS
 --token-slot <token slot> ::
         For V2 pools only. Use the token slot number to select among
         different bindings that use the same encryption method.
+--in-place ::
+        This is a mandatory option that must be set when requesting a
+        long-running in-place encryption operation. These operations are a
+        kind that change the pool's data as well as its metadata. Hence these
+        operations take a time that is linear in the size of the pool.
+        Additionally, these operations are run in place, that is, the
+        pool's data blocks are directly modified while it is in use. While
+        the operation is taking place, automatic administrative actions,
+        for example, extending filesystems, can not be taken on the pool.
+        Furthermore, user-initiated actions, such as adding a new device to
+        a pool are also disabled. The pool administrator should therefore
+        ensure that no administrative operations will become urgently
+        necessary while the encryption operation is running. Consider
+        backing up your data before initiating this operation.
 
 
 SIZE SPECIFICATION FORMAT FOR INPUT
@@ -338,6 +380,11 @@ Encryption Enabled: Clevis Configuration::
 	The Clevis configuration, if the pool is encrypted via Clevis. Only
         displayed if metadata version is 1 and encryption is enabled.
 
+Encryption Enabled: Last Time Reencrypted::
+        The last time the pool was re-encrypted. If the pool has never been
+        re-encrypted, the value is "Never". Only displayed if metadata
+        version is 2 and encryption is enabled.
+
 Encryption Enabled: Free Token Slots Remaining::
         The number of token slots remaining that can accommodate new
         bindings, followed by a list of binding descriptions, ordered by

setup.cfg

@@ -26,7 +26,7 @@ classifiers=
 python_requires = >=3.12
 install_requires =
     dbus-client-gen>=0.4
-    dbus-python-client-gen>=0.7
+    dbus-python-client-gen>=0.8.4
     justbytes>=0.14
     packaging
     psutil

src/stratis_cli/_actions/__init__.py

@@ -22,6 +22,7 @@
     MANAGER_0_INTERFACE,
     POOL_INTERFACE,
 )
+from ._crypt import CryptActions
 from ._debug import (
     BlockdevDebugActions,
     FilesystemDebugActions,
@@ -34,3 +35,4 @@
 from ._stratis import StratisActions
 from ._stratisd_version import check_stratisd_version
 from ._top import TopActions
+from ._utils import get_errors

src/stratis_cli/_actions/_crypt.py

@@ -0,0 +1,184 @@
+# Copyright 2025 Red Hat, Inc.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#     http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+"""
+Miscellaneous whole pool encryption actions.
+"""
+
+# isort: STDLIB
+import json
+from argparse import Namespace
+
+from .._constants import PoolId
+from .._errors import (
+    StratisCliEngineError,
+    StratisCliIncoherenceError,
+    StratisCliInPlaceNotSpecified,
+    StratisCliNoChangeError,
+)
+from .._stratisd_constants import StratisdErrors
+from ._connection import get_object
+from ._constants import TOP_OBJECT
+from ._utils import long_running_operation
+
+
+class CryptActions:
+    """
+    Whole pool encryption actions.
+    """
+
+    @staticmethod
+    @long_running_operation(method_names=["EncryptPool"])
+    def encrypt(namespace: Namespace):
+        """
+        Encrypt a previously unencrypted pool.
+        """
+
+        if not namespace.in_place:
+            raise StratisCliInPlaceNotSpecified()
+
+        # pylint: disable=import-outside-toplevel
+        from ._data import MOPool, ObjectManager, Pool, pools
+
+        pool_id = PoolId.from_parser_namespace(namespace)
+        assert pool_id is not None
+
+        proxy = get_object(TOP_OBJECT)
+
+        managed_objects = ObjectManager.Methods.GetManagedObjects(proxy, {})
+
+        (pool_object_path, mopool) = next(
+            pools(props=pool_id.managed_objects_key())
+            .require_unique_match(True)
+            .search(managed_objects)
+        )
+
+        if bool(MOPool(mopool).Encrypted()):
+            raise StratisCliNoChangeError("encryption on", pool_id)
+
+        (changed, return_code, message) = Pool.Methods.EncryptPool(
+            get_object(pool_object_path),
+            {
+                "key_descs": (
+                    []
+                    if namespace.key_desc is None
+                    else [((False, 0), namespace.key_desc)]
+                ),
+                "clevis_infos": (
+                    []
+                    if namespace.clevis is None
+                    else [
+                        (
+                            (False, 0),
+                            namespace.clevis.pin,
+                            json.dumps(namespace.clevis.config),
+                        )
+                    ]
+                ),
+            },
+            timeout=10,
+        )
+
+        if return_code != StratisdErrors.OK:
+            raise StratisCliEngineError(return_code, message)
+
+        if not changed:  # pragma: no cover
+            raise StratisCliIncoherenceError(
+                f"Expected to change {pool_id} encryption status to "
+                "encrypted, but stratisd reports that it did not change "
+                "the encryption status"
+            )
+
+    @staticmethod
+    @long_running_operation(method_names=["DecryptPool"])
+    def unencrypt(namespace: Namespace):
+        """
+        Unencrypt a previously encrypted pool.
+        """
+        if not namespace.in_place:
+            raise StratisCliInPlaceNotSpecified()
+
+        # pylint: disable=import-outside-toplevel
+        from ._data import MOPool, ObjectManager, Pool, pools
+
+        pool_id = PoolId.from_parser_namespace(namespace)
+        assert pool_id is not None
+
+        proxy = get_object(TOP_OBJECT)
+
+        managed_objects = ObjectManager.Methods.GetManagedObjects(proxy, {})
+
+        (pool_object_path, mopool) = next(
+            pools(props=pool_id.managed_objects_key())
+            .require_unique_match(True)
+            .search(managed_objects)
+        )
+
+        if not bool(MOPool(mopool).Encrypted()):
+            raise StratisCliNoChangeError("encryption off", pool_id)
+
+        (changed, return_code, message) = Pool.Methods.DecryptPool(
+            get_object(pool_object_path),
+            {},
+            timeout=10,
+        )
+
+        if return_code != StratisdErrors.OK:  # pragma: no cover
+            raise StratisCliEngineError(return_code, message)
+
+        if not changed:  # pragma: no cover
+            raise StratisCliIncoherenceError(
+                f"Expected to change {pool_id} encryption status to "
+                "unencrypted, but stratisd reports that it did not change "
+                "the pool's encryption status"
+            )
+
+    @staticmethod
+    @long_running_operation(method_names=["ReencryptPool"])
+    def reencrypt(namespace: Namespace):
+        """
+        Reencrypt an already encrypted pool with a new key.
+        """
+        if not namespace.in_place:
+            raise StratisCliInPlaceNotSpecified()
+
+        # pylint: disable=import-outside-toplevel
+        from ._data import ObjectManager, Pool, pools
+
+        pool_id = PoolId.from_parser_namespace(namespace)
+        assert pool_id is not None
+
+        proxy = get_object(TOP_OBJECT)
+
+        managed_objects = ObjectManager.Methods.GetManagedObjects(proxy, {})
+
+        (pool_object_path, _) = next(
+            pools(props=pool_id.managed_objects_key())
+            .require_unique_match(True)
+            .search(managed_objects)
+        )
+
+        (changed, return_code, message) = Pool.Methods.ReencryptPool(
+            get_object(pool_object_path),
+            {},
+            timeout=10,
+        )
+
+        if return_code != StratisdErrors.OK:
+            raise StratisCliEngineError(return_code, message)
+
+        if not changed:  # pragma: no cover
+            raise StratisCliIncoherenceError(
+                f"Expected to reencrypt {pool_id} with a new key but stratisd "
+                "reports that it did not perform the operation"
+            )

src/stratis_cli/_actions/_data.py

@@ -44,7 +44,7 @@
     "deferred until after the stratis_cli module has been fully loaded."
 )
 
-DBUS_TIMEOUT_SECONDS = 120
+DBUS_TIMEOUT_SECONDS = 60
 
 # Specification for the lowest manager interface supported by the major
 # version of stratisd on which this version of the CLI depends.

src/stratis_cli/_actions/_introspect.py

@@ -185,12 +185,24 @@
       <arg name="return_code" type="q" direction="out" />
       <arg name="return_string" type="s" direction="out" />
     </method>
+    <method name="DecryptPool">
+      <arg name="results" type="b" direction="out" />
+      <arg name="return_code" type="q" direction="out" />
+      <arg name="return_string" type="s" direction="out" />
+    </method>
     <method name="DestroyFilesystems">
       <arg name="filesystems" type="ao" direction="in" />
       <arg name="results" type="(bas)" direction="out" />
       <arg name="return_code" type="q" direction="out" />
       <arg name="return_string" type="s" direction="out" />
     </method>
+    <method name="EncryptPool">
+      <arg name="key_descs" type="a((bu)s)" direction="in" />
+      <arg name="clevis_infos" type="a((bu)ss)" direction="in" />
+      <arg name="results" type="b" direction="out" />
+      <arg name="return_code" type="q" direction="out" />
+      <arg name="return_string" type="s" direction="out" />
+    </method>
     <method name="FilesystemMetadata">
       <arg name="fs_name" type="(bs)" direction="in" />
       <arg name="current" type="b" direction="in" />
@@ -229,6 +241,11 @@
       <arg name="return_code" type="q" direction="out" />
       <arg name="return_string" type="s" direction="out" />
     </method>
+    <method name="ReencryptPool">
+      <arg name="results" type="b" direction="out" />
+      <arg name="return_code" type="q" direction="out" />
+      <arg name="return_string" type="s" direction="out" />
+    </method>
     <method name="SetName">
       <arg name="name" type="s" direction="in" />
       <arg name="result" type="(bs)" direction="out" />
@@ -257,13 +274,12 @@
     <property name="AllocatedSize" type="s" access="read" />
     <property name="AvailableActions" type="s" access="read" />
     <property name="ClevisInfos" type="v" access="read" />
-    <property name="Encrypted" type="b" access="read">
-      <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="const" />
-    </property>
+    <property name="Encrypted" type="b" access="read" />
     <property name="FreeTokenSlots" type="(by)" access="read" />
     <property name="FsLimit" type="t" access="readwrite" />
     <property name="HasCache" type="b" access="read" />
     <property name="KeyDescriptions" type="v" access="read" />
+    <property name="LastReencryptedTimestamp" type="(bs)" access="read" />
     <property name="MetadataVersion" type="t" access="read">
       <annotation name="org.freedesktop.DBus.Property.EmitsChangedSignal" value="const" />
     </property>

src/stratis_cli/_actions/_list_pool.py

@@ -28,6 +28,7 @@
 from uuid import UUID
 
 # isort: THIRDPARTY
+from dateutil import parser as date_parser
 from justbytes import Range
 
 # isort: FIRSTPARTY
@@ -435,6 +436,18 @@ def _print_detail_view(
         elif encrypted is True:
             print("Encryption Enabled: Yes")
 
+            try:
+                reencrypted = get_property(
+                    mopool.LastReencryptedTimestamp(),
+                    lambda t: date_parser.isoparse(t)
+                    .astimezone()
+                    .strftime("%b %d %Y %H:%M"),
+                    "Never",
+                )
+            except DbusClientMissingPropertyError:
+                reencrypted = TABLE_UNKNOWN_STRING
+            print(f"    Last Time Reencrypted: {reencrypted}")
+
             if metadata_version is MetadataVersion.V1:  # pragma: no cover
                 try:
                     key_description_str = _non_existent_or_inconsistent_to_str(