fix cef main loop on mac obs-browser#49
Merged
Merged
Conversation
* call CefDoMessageLoopWork instead of CefRunMessageLoop which is a blocking call * QoL change for dev: update ExecuteTask/ExecuteSyncTask to check if invoked on main thread. When debugging slobs, we're on main thread. But when this code is invoked from SLD, we're running from an async thread. so this code enables the task to be executed with no thought or care where its been run from.
6 tasks
summeroff
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making a correction to my previous commit c404f38 which actually breaks SLD because it can block main queue. Reworking this code to avoid calling
CefRunMessageLoopon main loop because that will block main.BrowserManagerThread(APPLE does not need to spin up this thread, CEF runs on main loop)ExecuteTask()andExecuteSyncTask()so these functions can be invoked from main thread if desired w/o throwing an exception (w/o this change you'll crash if you run OBS.app directly because this frontend runs everything from main thread)CefDoMessageLoopWorkto handle CEF messages on main thread which is non-blocking