Skip to content

feat: rename packageService to pulsarPackageService #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiangpengcheng merged 8 commits into from
Mar 23, 2026
Merged

feat: rename packageService to pulsarPackageService #832

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ed070dd
feat: rename packageService to pulsarPackageService
jiangpengcheng Mar 20, 2026
aed5301
fix
jiangpengcheng Mar 20, 2026
893fd42
fix ci
jiangpengcheng Mar 20, 2026
feb2913
fix vulner
jiangpengcheng Mar 21, 2026
f15ba38
fix test
jiangpengcheng Mar 21, 2026
d1f5b2c
generate
jiangpengcheng Mar 21, 2026
7fae6cf
fix test
jiangpengcheng Mar 23, 2026
5e4225f
fix test
jiangpengcheng Mar 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .ci/olm-tests/catalog.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,4 @@ metadata:
namespace: olm
spec:
sourceType: grpc
image: kind-registry:5000/streamnativeio/function-mesh-catalog:v0.26.1
image: localhost:5000/streamnativeio/function-mesh-catalog:v0.26.1
2 changes: 1 addition & 1 deletion ...tests/integration-oauth2/cases/java-download-function-with-package-service/manifests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ spec:
issuerUrl: https://auth.sncloud-stg.dev/
keySecretName: sn-platform-oauth2-private-key
keySecretKey: auth.json
packageService:
pulsarPackageService:
pulsarConfig: "test-pulsar-package-service"
tlsConfig:
enabled: false
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/olm-verify.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,14 @@ jobs:
sudo chmod +x /usr/bin/yq
yq --help

- name: Kubernetes KinD Cluster
uses: container-tools/kind-action@v1
with:
node_image: kindest/node:v1.23.17
- name: Create kind cluster
run: |
hack/kind-cluster-build.sh --name olm-verify -c 1 -v 10 --k8sVersion v1.23.17

- name: Build RedHat certificated bundle And Publish to Quay
env:
DOCKER_REPO: kind-registry:5000/streamnativeio
IMAGE_TAG_BASE: kind-registry:5000/streamnativeio/function-mesh
DOCKER_REPO: localhost:5000/streamnativeio
IMAGE_TAG_BASE: localhost:5000/streamnativeio/function-mesh
CATALOG_BRANCH_TAG: latest
run: |
echo $VERSION
Expand Down
4 changes: 2 additions & 2 deletions api/compute/v1alpha1/function_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ type FunctionSpec struct {

// +kubebuilder:validation:Required
Messaging `json:",inline"`
// PackageService is used for package download when specified.
// PulsarPackageService is used for package download when specified.
// If empty, the package download falls back to Messaging.Pulsar.
PackageService *PulsarMessaging `json:"packageService,omitempty"`
PulsarPackageService *PulsarMessaging `json:"pulsarPackageService,omitempty"`

// +kubebuilder:validation:Required
Runtime `json:",inline"`
Comment on lines 94 to 99
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the JSON field from packageService to pulsarPackageService is a breaking API change for existing CRs/manifests: objects stored with the old field will no longer validate/round-trip cleanly against the updated CRD. If backward compatibility across upgrades is required, consider keeping packageService as a deprecated alias (and mapping it in reconciliation/validation), or adding a CRD conversion strategy/webhook to translate between the old and new field names during upgrades.

Copilot uses AI. Check for mistakes.
Expand Down
4 changes: 2 additions & 2 deletions api/compute/v1alpha1/sink_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ type SinkSpec struct {

// +kubebuilder:validation:Required
Messaging `json:",inline"`
// PackageService is used for package download when specified.
// PulsarPackageService is used for package download when specified.
// If empty, the package download falls back to Messaging.Pulsar.
PackageService *PulsarMessaging `json:"packageService,omitempty"`
PulsarPackageService *PulsarMessaging `json:"pulsarPackageService,omitempty"`
// +kubebuilder:validation:Required
Runtime `json:",inline"`

Comment on lines 87 to 92
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the JSON field from packageService to pulsarPackageService is a breaking API change for existing CRs/manifests: objects stored with the old field will no longer validate/round-trip cleanly against the updated CRD. If backward compatibility across upgrades is required, consider keeping packageService as a deprecated alias (and mapping it in reconciliation/validation), or adding a CRD conversion strategy/webhook to translate between the old and new field names during upgrades.

Copilot uses AI. Check for mistakes.
Expand Down
4 changes: 2 additions & 2 deletions api/compute/v1alpha1/source_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,9 +82,9 @@ type SourceSpec struct {

// +kubebuilder:validation:Required
Messaging `json:",inline"`
// PackageService is used for package download when specified.
// PulsarPackageService is used for package download when specified.
// If empty, the package download falls back to Messaging.Pulsar.
PackageService *PulsarMessaging `json:"packageService,omitempty"`
PulsarPackageService *PulsarMessaging `json:"pulsarPackageService,omitempty"`

// +kubebuilder:validation:Required
Runtime `json:",inline"`
Expand Down
12 changes: 6 additions & 6 deletions api/compute/v1alpha1/zz_generated.deepcopy.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading