Add automatic temperature sensor selection for daemon#90
Open
leonardoman9 wants to merge 1 commit into
Open
Conversation
kbrddestroyer
requested changes
Jul 2, 2026
|
|
||
| try: | ||
| gif = Image.open(gif_path) | ||
| from PIL import Image as PILImage |
Collaborator
There was a problem hiding this comment.
Why is it here and not with other imports?
| step = self.step | ||
|
|
||
| canvas = Image.new("RGBA", gif.size, (0, 0, 0, 255)) | ||
| from PIL import Image as PILImage |
Collaborator
There was a problem hiding this comment.
Could be moved to other imports to avoid code duplication
|
|
||
| RULE_FILE_PATH = ETC_FOLDER + "/udev/rules.d/99-epomaker-rt100.rules" | ||
| TMP_FILE_PATH = TMP_FOLDER + "/99-epomaker-rt100.rules" | ||
| PATH_TO_DEFAULT_CONFIG = "src/epomakercontroller/configs/default.json" |
Collaborator
There was a problem hiding this comment.
That could lead to errors when this file moved somewhere, I'd better leave it with path
| from epomakercontroller.utils.sensors import select_temp_device | ||
|
|
||
|
|
||
| def test_select_temp_device_prefers_cpu_sensor() -> None: |
Collaborator
There was a problem hiding this comment.
use @pytest.mark.parametrise
| home_dir = Path(os.path.abspath(os.curdir)) | ||
| config_dir = home_dir / CONFIG_DIRECTORY | ||
| return config_dir | ||
| return Path.home() / CONFIG_DIRECTORY |
Collaborator
There was a problem hiding this comment.
I think it would be better to leave previous functionality and not using home directory
Collaborator
|
Was this code AI-generated by any chance? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional automatic temperature sensor selection mode for the daemon:
epomakercontroller start-daemon --auto-tempWhen enabled, the daemon chooses a temperature sensor automatically instead of requiring users to
manually inspect list-temp-devices and pass a key such as coretemp-0.
The selection policy is conservative:
This avoids choosing NVIDIA/AMD GPU sensors by default, since repeated GPU sensor polling can be more
disruptive on some systems.
Changes
behavior
Example
$ epomakercontroller list-temp-devices
DEVICE KEY CURRENT TEMPERATURE AUTO
coretemp-0 52.0°C *
coretemp-1 48.0°C
coretemp-2 49.0°C
$ epomakercontroller start-daemon --auto-temp
Testing
Tested locally on Arch Linux with an Epomaker RT100 Wired.
MPLBACKEND=Agg python -m pytest
Result:
26 passed, 2 warnings in 10.51s
Warnings observed:
test_main.py::test_read_and_decode_bytes
Manual checks:
epomakercontroller send-time
epomakercontroller list-temp-devices
epomakercontroller start-daemon coretemp-0