Skip to content

[WIP] Discrete adjoint multi-zone for python wrapper #2787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EvertBunschoten wants to merge 5 commits into
base: develop
Choose a base branch
from
+42 −31
Open

[WIP] Discrete adjoint multi-zone for python wrapper #2787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
594c388
Change nested classes to friend classes
EvertBunschoten Apr 15, 2026
2821ba1
Include discrete adjoint multizone driver in python wrapper
EvertBunschoten Apr 15, 2026
e55e591
Merge branch 'develop' into feature_multizone_disc_adj_pywrapper
EvertBunschoten Apr 15, 2026
f0d9fac
Re-define AdjointProduct and Identity as template classes
EvertBunschoten May 11, 2026
1781378
Merge branch 'develop' of https://github.com/su2code/SU2 into feature…
EvertBunschoten May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 38 additions & 29 deletions SU2_CFD/include/drivers/CDiscAdjMultizoneDriver.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,38 +36,21 @@
* \brief Block Gauss-Seidel driver for multizone / multiphysics discrete adjoint problems.
* \ingroup DiscAdj
*/
class CDiscAdjMultizoneDriver : public CMultizoneDriver {

protected:
#ifdef CODI_FORWARD_TYPE
using Scalar = su2double;
#else
using Scalar = passivedouble;
#endif

class AdjointProduct : public CMatrixVectorProduct<Scalar> {
public:
CDiscAdjMultizoneDriver* const driver;
const unsigned short iZone = 0;
mutable unsigned long iInnerIter = 0;

AdjointProduct(CDiscAdjMultizoneDriver* d, unsigned short i) : driver(d), iZone(i) {}

inline void operator()(const CSysVector<Scalar> & u, CSysVector<Scalar> & v) const override {
driver->SetAllSolutions(iZone, true, u);
driver->Iterate(iZone, iInnerIter, true);
driver->GetAllSolutions(iZone, true, v);
v -= u;
++iInnerIter;
}
};
template<class> class AdjointProduct;
template<class> class Identity;

class Identity : public CPreconditioner<Scalar> {
public:
inline bool IsIdentity() const override { return true; }
inline void operator()(const CSysVector<Scalar> & u, CSysVector<Scalar> & v) const override { v = u; }
};
class CDiscAdjMultizoneDriver : public CMultizoneDriver {

protected:
#ifdef CODI_FORWARD_TYPE
using Scalar = su2double;
#else
using Scalar = passivedouble;
#endif

friend class AdjointProduct<Scalar>;
friend class Identity<Scalar>;
/*!
* \brief Kinds of recordings.
*/
Expand Down Expand Up @@ -304,3 +287,29 @@ class CDiscAdjMultizoneDriver : public CMultizoneDriver {
}

};


template<class Scalar_t>
class AdjointProduct : public CMatrixVectorProduct<Scalar_t> {
public:
CDiscAdjMultizoneDriver* const driver;
const unsigned short iZone = 0;
mutable unsigned long iInnerIter = 0;

AdjointProduct(CDiscAdjMultizoneDriver* d, unsigned short i) : driver(d), iZone(i) {}

inline void operator()(const CSysVector<Scalar_t> & u, CSysVector<Scalar_t> & v) const override {
driver->SetAllSolutions(iZone, true, u);
driver->Iterate(iZone, iInnerIter, true);
driver->GetAllSolutions(iZone, true, v);
v -= u;
++iInnerIter;
}
};

template<class Scalar_t>
class Identity : public CPreconditioner<Scalar_t> {
public:
inline bool IsIdentity() const override { return true; }
inline void operator()(const CSysVector<Scalar_t> & u, CSysVector<Scalar_t> & v) const override { v = u; }
};
4 changes: 2 additions & 2 deletions SU2_CFD/src/drivers/CDiscAdjMultizoneDriver.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@ void CDiscAdjMultizoneDriver::KrylovInnerIters(unsigned short iZone) {
GetAllSolutions(iZone, true, AdjSol[iZone]);

const bool monitor = config_container[iZone]->GetWrt_ZoneConv();
const auto product = AdjointProduct(this, iZone);
const auto product = AdjointProduct<Scalar>(this, iZone);

/*--- Manipulate the screen output frequency to avoid printing garbage. ---*/
const auto wrtFreq = config_container[iZone]->GetScreen_Wrt_Freq(2);
Expand All @@ -388,7 +388,7 @@ void CDiscAdjMultizoneDriver::KrylovInnerIters(unsigned short iZone) {
Scalar eps_l = 0.0;
Scalar tol_l = KrylovTol / eps;
auto iter = min(totalIter-2ul, config_container[iZone]->GetnQuasiNewtonSamples()-2ul);
iter = LinSolver[iZone].FGCRODR_LinSolver(AdjRHS[iZone], AdjSol[iZone], product, Identity(),
iter = LinSolver[iZone].FGCRODR_LinSolver(AdjRHS[iZone], AdjSol[iZone], product, Identity<Scalar>(),
tol_l, iter, eps_l, monitor, config_container[iZone],
FgcrodrMode::SAME_MAT, iter);
totalIter -= iter+1;
Expand Down
2 changes: 2 additions & 0 deletions SU2_PY/pySU2/pySU2ad.i
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ threads="1"
%{
#include "../../Common/include/containers/CPyWrapperMatrixView.hpp"
#include "../../SU2_CFD/include/drivers/CDiscAdjSinglezoneDriver.hpp"
#include "../../SU2_CFD/include/drivers/CDiscAdjMultizoneDriver.hpp"
#include "../../SU2_CFD/include/drivers/CDriver.hpp"
#include "../../SU2_CFD/include/drivers/CDriverBase.hpp"
#include "../../SU2_CFD/include/drivers/CMultizoneDriver.hpp"
Expand Down Expand Up @@ -98,4 +99,5 @@ const unsigned int ZONE_1 = 1; /*!< \brief Definition of the first grid domain.
%include "../../SU2_CFD/include/drivers/CSinglezoneDriver.hpp"
%include "../../SU2_CFD/include/drivers/CMultizoneDriver.hpp"
%include "../../SU2_CFD/include/drivers/CDiscAdjSinglezoneDriver.hpp"
%include "../../SU2_CFD/include/drivers/CDiscAdjMultizoneDriver.hpp"
%include "../../SU2_DEF/include/drivers/CDiscAdjDeformationDriver.hpp"
Loading