-
Notifications
You must be signed in to change notification settings - Fork 10
Enable quota-based instant delegation with era restrictions #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 12 commits
e61c7ee
395ce30
b0cce19
ec34754
b57e74e
a6c9f26
56c7665
58ceff3
bcd2d3d
a20f8e3
ef19c05
7fb4c2f
cbd71ee
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,23 +1,15 @@ | ||
| changesetBaseRefs: | ||
| - main | ||
| - origin/main | ||
| - main | ||
| - origin/main | ||
|
|
||
| enableImmutableInstalls: false | ||
|
|
||
| enableProgressBars: false | ||
|
|
||
| nodeLinker: node-modules | ||
|
|
||
| npmAuthToken: '${NPM_TOKEN:-}' | ||
| npmAuthToken: "${NPM_TOKEN:-}" | ||
|
|
||
| npmPublishRegistry: 'https://registry.npmjs.org' | ||
| npmPublishRegistry: "https://registry.npmjs.org" | ||
|
|
||
| plugins: | ||
| - path: .yarn/plugins/@yarnpkg/plugin-typescript.cjs | ||
| spec: '@yarnpkg/plugin-typescript' | ||
| - path: .yarn/plugins/@yarnpkg/plugin-version.cjs | ||
| spec: '@yarnpkg/plugin-version' | ||
| - path: .yarn/plugins/@yarnpkg/plugin-interactive-tools.cjs | ||
| spec: '@yarnpkg/plugin-interactive-tools' | ||
|
|
||
| yarnPath: .yarn/releases/yarn-3.6.4.cjs | ||
| yarnPath: .yarn/releases/yarn-4.10.3.cjs |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -101,5 +101,24 @@ | |
| "prettier --write --plugin=prettier-plugin-solidity" | ||
| ] | ||
| }, | ||
| "packageManager": "yarn@3.6.4" | ||
| "resolutions": { | ||
| "@ethersproject/abstract-provider": "~5.5.1", | ||
| "@ethersproject/abstract-signer": "~5.5.0", | ||
| "@ethersproject/address": "~5.5.0", | ||
| "@ethersproject/bignumber": "~5.5.0", | ||
| "@ethersproject/bytes": "~5.5.0", | ||
| "@ethersproject/constants": "~5.5.0", | ||
| "@ethersproject/contracts": "~5.5.0", | ||
| "@ethersproject/hash": "~5.5.0", | ||
| "@ethersproject/keccak256": "~5.5.0", | ||
| "@ethersproject/logger": "~5.5.0", | ||
| "@ethersproject/networks": "~5.5.2", | ||
| "@ethersproject/properties": "~5.5.0", | ||
| "@ethersproject/providers": "~5.5.3", | ||
| "@ethersproject/signing-key": "~5.5.0", | ||
| "@ethersproject/strings": "~5.5.0", | ||
| "@ethersproject/transactions": "~5.5.0", | ||
| "@ethersproject/wallet": "~5.5.0" | ||
| }, | ||
| "packageManager": "yarn@4.10.3" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainVerify Yarn 4 compatibility across the project. Upgrading from Yarn 3.6.4 to 4.10.3 is a major version change with potential breaking changes in:
Ensure all CI/CD pipelines, developer environments, and scripts are compatible with Yarn 4. 🏁 Script executed: #!/bin/bash
# Description: Verify yarn configuration and check for potential incompatibilities
# Expected: Find .yarnrc.yml and scripts that invoke yarn commands
echo "=== Checking .yarnrc.yml configuration ==="
fd -t f '.yarnrc.yml' --exec cat {}
echo -e "\n=== Finding scripts that invoke yarn ==="
rg -n 'yarn ' --type=sh --type=json
echo -e "\n=== Checking package.json scripts for yarn-specific features ==="
cat package.json | jq '.scripts'Length of output: 1873 I'll continue verification by checking for Yarn configuration directory, CI/CD pipelines, and researching Yarn 4 breaking changes. 🏁 Script executed: #!/bin/bash
# Check for .yarn directory and CI/CD configuration
echo "=== Checking for .yarn directory ==="
fd -t d '^\.yarn$'
echo -e "\n=== Checking for CI/CD pipeline files ==="
fd -t f '\.(github|gitlab-ci|circle|travis)' -x echo {}
echo -e "\n=== Checking for yarn lock file and its format ==="
fd -t f 'yarn.lock' -x head -20 {}
echo -e "\n=== Searching for yarn plugin references ==="
rg -n '@yarn|yarnpkg' --type=json -C 2Length of output: 1072 🌐 Web query: 💡 Result: Major breaking changes when upgrading from Yarn 3.x → Yarn 4.x:
Sources: Yarn 4 release notes / breaking changes. [1] 🏁 Script executed: #!/bin/bash
# Check Node.js version requirement and .github workflows with corrected commands
echo "=== Checking Node.js version requirement in package.json ==="
cat package.json | jq '.engines'
echo -e "\n=== Checking for .nvmrc ==="
fd -t f '.nvmrc' -x cat {}
echo -e "\n=== Checking for .github directory (with -H flag) ==="
fd -t d -H '^\.github$'
echo -e "\n=== Checking for any github workflows ==="
fd -t f -H 'workflows' --exec ls -la {} \;
echo -e "\n=== Checking for script files that call yarn ==="
fd -t f '\.sh$' -x grep -l 'yarn' {} \;Length of output: 251 🌐 Web query: 💡 Result: Short answer: Yarn 4 requires Node.js 18 or newer (the release notes state Node.js 18+; the changelog notes support dropped for versions lower than 18.12). [1][2] Notes:
Sources:
🏁 Script executed: #!/bin/bash
# Direct check for GitHub Actions workflows and .github contents
echo "=== Checking .github directory contents ==="
find .github -type f 2>/dev/null | head -20
echo -e "\n=== Checking for GitHub Actions workflow files ==="
fd -H -t f '\.(yml|yaml)$' '.github/workflows/'
echo -e "\n=== Checking .gitignore for node version hints ==="
cat .gitignore 2>/dev/null | grep -i 'node\|nvmrc' || echo "No node-related patterns found"
echo -e "\n=== Checking for Corepack configuration ==="
cat .npmrc 2>/dev/null || echo "No .npmrc found"Length of output: 638 🏁 Script executed: #!/bin/bash
# Check Node.js and yarn version setup in workflows
echo "=== Checking workflow files for Node.js and yarn setup ==="
for workflow in .github/workflows/*.yml; do
echo -e "\n--- $workflow ---"
grep -E 'node-version|setup-node|yarn' "$workflow" | head -10
done
echo -e "\n=== Full check of pr.yml (main CI pipeline) ==="
cat .github/workflows/pr.yml | grep -A5 -B5 'node-version\|setup-node' || echo "Checking entire pr.yml structure..."
cat .github/workflows/pr.ymlLength of output: 2753 🌐 Web query: 💡 Result: Short answer: setup-node@v1 does not automatically enable or configure Corepack/Yarn‑4 for you — you must enable Corepack (or install Yarn 4) in your workflow before running yarn. See Corepack docs and examples (add a step: run: corepack enable). [1][2][3] Recommended minimal workflow change:
References
Add The package.json upgrade to Yarn 4.10.3 is specified via the Add a step before each yarn invocation: - run: corepack enableThis ensures CI uses the specified yarn@4.10.3 from package.json rather than defaulting to Yarn 1.x. 🤖 Prompt for AI Agents |
||
| } | ||
Uh oh!
There was an error while loading. Please reload this page.