XXX: Play with CI to set up IWYU#151
Draft
ingomueller-net wants to merge 3 commits intosubstrait-io:mainfrom
Draft
XXX: Play with CI to set up IWYU#151ingomueller-net wants to merge 3 commits intosubstrait-io:mainfrom
ingomueller-net wants to merge 3 commits intosubstrait-io:mainfrom
Conversation
ingomueller-net
changed the title
ingomueller-net
force-pushed
the
iwyu-ci
branch
15 times, most recently
from
fdb8e1e to
ca5e1af
Compare
This PR applies more fixes found by `clang-tidy`. Curiously, they only show up with substrait-io#148, which consumes `abseil-cpp` differently. Signed-off-by: Ingo Müller <ingomueller@google.com>
For CI, the IWYU tools needs to be built from sources. However, the result is cached and the steps to build the tool are skipped on cache hit, such that the end-to-end time for setting up the tool only requires 7s on cache hit (and 60x on a miss).
Signed-off-by: Ingo Müller <ingomueller@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.