build: remove bogous work-around for problems with sframes#199
Merged
ingomueller-net merged 1 commit intosubstrait-io:mainfrom Apr 1, 2026
Merged
Conversation
ingomueller-net
force-pushed
the
remove-sframe-workaround
branch
2 times, most recently
from
5a91e35 to
17dae50
Compare
briansuchy-goog
previously approved these changes
Mar 31, 2026
Collaborator
Author
|
@googlebot rescan |
ingomueller-net
force-pushed
the
remove-sframe-workaround
branch
from
17dae50 to
76e2a9d
Compare
dshaaban01
approved these changes
Apr 1, 2026
Collaborator
Author
|
Need to close and re-open to make CLA assistant approve. |
auto-merge was automatically disabled
April 1, 2026 15:54
Pull request was closed
ingomueller-net
force-pushed
the
remove-sframe-workaround
branch
from
76e2a9d to
e6b15a6
Compare
Collaborator
Author
|
Need to close and re-open to make CLA assistant re-check. |
This PR removes a work-around I thought would fix a problem with sframes I ran into on my machine leading to linker errors while compiling ANTLR (a dependency of substrait-cpp). Turns out that the root cause is that CMake uses the system default compiler for dependencies fetched with `FetchContent`, which is g++ on my machine (which emits sframes), which may then linked with compilation units compiled by a different compiler, which may break of LTO is enabled. The short-term solution is to set the `CC? and `CXX` environment variables to the same values as `CMAKE_*_COMPILER` when configuring. I have submitted a better mid-term solution as substrait-io/substrait-cpp#145. Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
force-pushed
the
remove-sframe-workaround
branch
from
e6b15a6 to
3969096
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes a work-around I thought would fix a problem with sframes I ran into on my machine leading to linker errors while compiling ANTLR (a dependency of substrait-cpp). Turns out that the root cause is that CMake uses the system default compiler for dependencies fetched with
FetchContent, which is g++ on my machine (which emits sframes), which may then linked with compilation units compiled by a different compiler, which may break of LTO is enabled. The short-term solution is to set theCC? andCXXenvironment variables to the same values asCMAKE_*_COMPILER` when configuring. I have submitted a better mid-term solution as substrait-io/substrait-cpp#145.