Repository navigation
change BSUP version to use major-minor pattern - #7532
Merged
Merged
Conversation
mattnibs
reviewed
Oct 26, 2026
| func (r *RowHeader) Deserialize(bytes [RowHeaderSize]byte) { | ||
| r.Version = binary.LittleEndian.Uint16(bytes[4:]) | ||
| r.Version.Major = bytes[4] | ||
| r.Version.Minor = bytes[5] |
Collaborator
There was a problem hiding this comment.
I'm a little concerned that we are boxed in with only have 256 minor changes until we have to bump the major- perhaps we should make the minor version field a uint16?
Collaborator
Author
There was a problem hiding this comment.
How about 10 bits for minor and 6 bits for major?
mattnibs
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.