Repository navigation
Conversation
The type checker previously modeled an unknown type with the
placeholder error({}). This commit changes it to the real any type,
fusion(all) (added as ontext.TypeAny()), and turns on complete fusion
in the checker’s fuser so that any stays wrapped as fusion(all)
instead of collapsing to the bare all type when fused.
Since fused types now keep their fusion wrappers, the checker looks
at a type’s underlying type through a new under helper, which removes
named types and a fusion wrapper (but leaves any alone). This replaces
super.TypeUnder throughout the checker. isUnknown is now super.IsTypeAny.
The places that recognized the old placeholder through *super.TypeError
cases (deref, isContainer, unnestCheck, in, hasString) now check isUnknown
up front.
The only test change is in from-type.yaml, where the type checker now
more accurately keeps the input’s field fusions,
e.g., {x:fusion(int64|missing),...}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type checker previously modeled an unknown type with the placeholder error({}). This commit changes it to the real any type, fusion(all) (added as ontext.TypeAny()), and turns on complete fusion in the checker’s fuser so that any stays wrapped as fusion(all) instead of collapsing to the bare all type when fused.
Since fused types now keep their fusion wrappers, the checker looks at a type’s underlying type through a new under helper, which removes named types and a fusion wrapper (but leaves any alone). This replaces super.TypeUnder throughout the checker. isUnknown is now super.IsTypeAny. The places that recognized the old placeholder through *super.TypeError cases (deref, isContainer, unnestCheck, in, hasString) now check isUnknown up front.
The only test change is in from-type.yaml, where the type checker now more accurately keeps the input’s field fusions,
e.g., {x:fusion(int64|missing),...}.