fix: Preserve table cell styles on Google Docs paste by Branc0 · Pull Request #2628 · superdoc-dev/superdoc

Branc0 · 2026-03-30T00:48:34Z

Summary

PR for the issue Issue #2150.

Table cell styling is lost when pasting from Google Docs. Cells with background colors are pasted as plain white; borders and padding are dropped.

Additionally, as a side effect of the main fixes, this PR solves two other issues:

Google Docs Pasted tables don't persist row height: I had to fix to test vertical alignment.
Duplicated borders on the intersections of cells. As we make the borders bigger, this gets more evident.

Steps for testing

Create a table in Google Docs with colored cells (e.g., this doc ).
Copy the table and paste it into SuperDoc.
Table cell background colors, borders, padding, and vertical alignment from pasted content are preserved.

…eDocs

…ding tests

Branc0 · 2026-03-30T00:51:09Z

+  const [bottomValuePt] = parseSizeUnit(style?.paddingBottom);
+  const [leftValuePt] = parseSizeUnit(style?.paddingLeft);
+
+  const top = halfPointToPixels(topValuePt);


I was searching for a helper function that converts PT to PX, and I noticed this has the same formula, so I used it despite the name being halfPoint. Let me know if it's okay...

@Branc0 the formula is right, just the name is confusing — we mentioned a shared helper in the inline review.

…egex pattern

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b77732f99

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Branc0 · 2026-03-30T01:50:15Z

Still WIP on this one:

The P1 issue from codex: tried a couple of fixes, but they introduced the duplicated border back
Integration test

caio-pizzol

@Branc0 tested with real Google Docs tables — backgrounds, borders (solid/dashed/dotted), merged cells, borderless cells, padding, column widths all working. no blockers.

test docs: basic styles · edge cases

basic styles — GDocs vs SuperDoc:

edge cases — GDocs vs SuperDoc:

left a few inline comments.

caio-pizzol · 2026-04-02T20:56:49Z

Hey @Branc0, this PR has had no activity for 3 days.

…borders

…ollapsed mode

…ble cell styles

caio-pizzol

@Branc0 tests and comment look good, resolved those two threads.

one thing: Google Docs uses <th> for header rows, but table-header.js only has rendering — it's missing the parsing side for the new attributes. so when you paste a table with a header row, the header cells lose their padding (and would lose background/borders/alignment too if they had any). table-cell.js has both sides, table-header.js needs the same. tested with this doc.

re: the halfPointToPixels name — keep it as is, it's fine.

Branc0 · 2026-04-08T00:34:27Z

Made some more changes:

Moved the parsing functions from extensions/table-cell/helpers to extensions/shared
Added the parsers for table-headers
Added more integration tests + table-headers tests

cssColorToHex returns values with the # prefix (e.g. #ffff00) but the rest of the system stores background colors as bare hex. renderDOM prepends # and the OOXML exporter writes background.color directly into shading.fill, so the mismatch produced ##ffff00 in CSS and #ffff00 in OOXML — both invalid. Also adds parseDOM → renderDOM round-trip tests to catch this class of format mismatch in the future.

caio-pizzol

@Branc0 all good from last round.

caught one bug — pasted background colors were stored with a # prefix, but the renderer adds its own #, so colors came out as ##ffff00 (broken). pushed a fix to your branch (6b14e6d8c) that strips the extra # at parse time, plus a round-trip test to prevent it from coming back.

approving.

superdoc-bot · 2026-04-08T01:35:29Z

🎉 This PR is included in vscode-ext v1.1.0-next.70

superdoc-bot · 2026-04-08T01:35:38Z

🎉 This PR is included in @superdoc-dev/react v1.0.0-next.24

The release is available on GitHub release

superdoc-bot · 2026-04-08T01:35:38Z

🎉 This PR is included in esign v2.2.0-next.28

The release is available on GitHub release

superdoc-bot · 2026-04-08T01:35:48Z

🎉 This PR is included in template-builder v1.3.0-next.30

The release is available on GitHub release

superdoc-bot · 2026-04-08T01:37:23Z

🎉 This PR is included in superdoc-cli v0.5.0-next.68

The release is available on GitHub release

superdoc-bot · 2026-04-08T01:39:04Z

🎉 This PR is included in superdoc-sdk v1.3.0-next.69

superdoc-bot · 2026-04-08T01:41:01Z

🎉 This PR is included in superdoc v1.24.0-next.67

The release is available on GitHub release

superdoc-bot · 2026-04-10T20:24:12Z

🎉 This PR is included in superdoc-sdk v1.4.0

superdoc-bot · 2026-04-10T20:34:26Z

🎉 This PR is included in superdoc v1.25.0

The release is available on GitHub release

superdoc-bot · 2026-04-10T22:30:16Z

🎉 This PR is included in superdoc-cli v0.6.0

The release is available on GitHub release

superdoc-bot · 2026-04-10T23:01:36Z

🎉 This PR is included in vscode-ext v2.3.0-next.1

superdoc-bot · 2026-04-10T23:02:01Z

🎉 This PR is included in template-builder v1.5.0-next.1

The release is available on GitHub release

superdoc-bot · 2026-04-10T23:02:04Z

🎉 This PR is included in esign v2.3.0-next.1

The release is available on GitHub release

Branc0 added 7 commits March 29, 2026 19:40

fix(table-cell): add background color parsing from inline styles

3a6b16c

fix(table-cell): dd cell margin parsing from inline styles

10b70b8

fix(table-row): persists row height on pasted content from html

65f7fdc

fix(table-cell): persists cell verticallAlignment on paste from googl…

ba53f9f

…eDocs

fix(test): tests for color and margin were failing

1ba1a41

feat(table-cell): add border parsing from inline styles and correspon…

ab5e67b

…ding tests

fix(table-row): prevent double interior borders

4861006

superdoc-bot bot added review: thorough community labels Mar 30, 2026

Branc0 commented Mar 30, 2026

View reviewed changes

Comment thread packages/super-editor/src/editors/v1/extensions/table-cell/table-cell.js Outdated

Branc0 commented Mar 30, 2026

View reviewed changes

Comment thread packages/super-editor/src/editors/v1/extensions/table-row/helpers/parseRowHeight.js

refactor(table-cell): optimize border style parsing using a dynamic r…

5b77732

…egex pattern

Branc0 commented Mar 30, 2026

View reviewed changes

Comment thread packages/super-editor/src/editors/v1/extensions/shared/parseCellBorders.js

Branc0 commented Mar 30, 2026

View reviewed changes

Comment thread packages/layout-engine/painters/dom/src/table/renderTableRow.ts

Branc0 marked this pull request as ready for review March 30, 2026 01:21

chatgpt-codex-connector bot reviewed Mar 30, 2026

View reviewed changes

refactor(table-cell): returns margins with value only

27946cb

caio-pizzol self-assigned this Mar 30, 2026

caio-pizzol reviewed Mar 30, 2026

View reviewed changes

Comment thread packages/super-editor/src/editors/v1/extensions/shared/parseCellBorders.js

Comment thread packages/layout-engine/painters/dom/src/table/renderTableRow.ts

Comment thread packages/super-editor/src/editors/v1/extensions/shared/parseCellMargins.js

Branc0 added 6 commits April 5, 2026 12:56

test(table-cell): increase cooverage and refactor tests

199a112

docs(renderTableRow): clarify assumptions about shared interior cell …

27ad316

…borders

test(renderTableRow): add test for non-final row border behavior in c…

36fd587

…ollapsed mode

Merge branch 'main' into 2150-preserve-table-styles

661df8c

Merge branch 'main' into 2150-preserve-table-styles

82b9242

test(table-cell): add integration tests for HTML paste handling of ta…

f8a6982

…ble cell styles

caio-pizzol reviewed Apr 6, 2026

View reviewed changes

Merge branch 'main' into 2150-preserve-table-styles

4331cd2

Branc0 added 3 commits April 7, 2026 20:54

feat(table): add parsing for table header and cell

fa48f6b

feat(table): move cell border rendering logic to shared

6271036

Merge branch 'main' into 2150-preserve-table-styles

54af30d

caio-pizzol approved these changes Apr 8, 2026

View reviewed changes

Merge branch 'main' into 2150-preserve-table-styles

62981a5

caio-pizzol enabled auto-merge April 8, 2026 01:25

caio-pizzol added this pull request to the merge queue Apr 8, 2026

Merged via the queue into superdoc-dev:main with commit 1768159 Apr 8, 2026
51 checks passed

superdoc-bot bot added the released on @next label Apr 8, 2026

superdoc-bot bot added the released on @latest label Apr 10, 2026

Conversation

Branc0 commented Mar 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Steps for testing

Uh oh!

Branc0 Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

caio-pizzol Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Branc0 commented Mar 30, 2026

Uh oh!

caio-pizzol left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

caio-pizzol commented Apr 2, 2026

Uh oh!

caio-pizzol left a comment

Choose a reason for hiding this comment

Uh oh!

Branc0 commented Apr 8, 2026

Uh oh!

caio-pizzol left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

superdoc-bot bot commented Apr 8, 2026

Uh oh!

superdoc-bot bot commented Apr 8, 2026

Uh oh!

superdoc-bot bot commented Apr 8, 2026

Uh oh!

superdoc-bot bot commented Apr 8, 2026

Uh oh!

superdoc-bot bot commented Apr 8, 2026

Uh oh!

superdoc-bot bot commented Apr 8, 2026

Uh oh!

superdoc-bot bot commented Apr 8, 2026

Uh oh!

superdoc-bot bot commented Apr 10, 2026

Uh oh!

superdoc-bot bot commented Apr 10, 2026

Uh oh!

superdoc-bot bot commented Apr 10, 2026

Uh oh!

superdoc-bot bot commented Apr 10, 2026

Uh oh!

superdoc-bot bot commented Apr 10, 2026

Uh oh!

superdoc-bot bot commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Branc0 commented Mar 30, 2026 •

edited

Loading

caio-pizzol left a comment •

edited

Loading