Create supergraph.go#178
Conversation
|
hold on , I have a PR relating to embedding |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a ChangesGraph command
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6d0fd2de2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| c.Flags().StringVarP(&opts.Output, "output", "o", "human", "output format: human|json|dot") | ||
| c.Flags().StringVar(&opts.Filter, "label", "", "filter nodes by label (File, Function, Class, …)") | ||
|
|
||
| rootCmd.AddCommand(c) |
There was a problem hiding this comment.
Remove duplicate graph command registration
cmd/graph.go:10-43 already registers the same Use: "graph [path]" command, so this second init adds a duplicate child to rootCmd. I checked Cobra v1.10.2: AddCommand appends each child to c.commands, and the default help iterates .Commands, so users will see duplicate graph entries in help/completions/docs rather than getting a distinct supergraph command. Remove this duplicate or give it a distinct command name.
Useful? React with 👍 / 👎.
What
beginning work on implementing contextplus into golang
Why
because go just works, and this repo deserves transliteration work commit
Test plan
make testpassesmake lintpassesSummary by CodeRabbit
graphcommand for analyzing a directory and displaying its dependency graph.