Create cache_embedding.go#179
Conversation
|
Warning Review limit reached
Next review available in: 55 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f7f580391f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // embeddingcache/embedding_cache.go | ||
| // Semantic Tool Output Caching with embedding similarity (inspired by Context+ patterns) | ||
|
|
||
| package embeddingcache |
There was a problem hiding this comment.
Keep the new file in package cmd
Adding this file under cmd/ with package embeddingcache makes the directory contain both cmd and embeddingcache packages; the rest of this directory's non-test files are package cmd, so building or testing the CLI will fail before this cache can be used. Move the cache into its own directory/package or change the package name to match the directory's existing package.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
okay @greynewell I dunno what would be the best file to change this into. your suggestion?
What
Why
performs embedding work within the kb cache and such
collaborate with contextplus repo?
Test plan
make testpassesmake lintpasses