fix(useDebounce, useThrottle): prevent unhandled rejection on cancel#413
Open
bxff wants to merge 2 commits into
Open
fix(useDebounce, useThrottle): prevent unhandled rejection on cancel#413bxff wants to merge 2 commits into
bxff wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: 4da898d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Add an internal no-op .catch() handler to the promise created by useDebounce and useThrottle. This prevents 'Uncaught (in promise) Cancelled' errors when cancel() is called without the caller having attached a .catch() handler. Callers who explicitly handle rejections (via .catch() or try/catch with await) are unaffected. Closes svecosystem#365
bxff
force-pushed
the
fix/debounce-cancel-uncaught-rejection
branch
from
84f51bf to
7e1a82c
Compare
bxff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
cancel()rejects the pending promise with"Cancelled", which throws anUncaught (in promise) Cancellederror when the caller doesn't have a.catch()handler attached (fire-and-forget usage).This adds an internal no-op
.catch()to the promise when it's created, so the rejection is always handled internally. Callers who explicitly use.catch()orawait+ try/catch still receive the rejection as before.The same fix is applied to
useThrottlewhich has the identical issue (noted in the comments on #365).Closes #365