fix(config): add missing queryConfigEnabled to type-cast mappings#10838
Open
yogeshwaran-c wants to merge 1 commit into
Open
fix(config): add missing queryConfigEnabled to type-cast mappings#10838yogeshwaran-c wants to merge 1 commit into
yogeshwaran-c wants to merge 1 commit into
Conversation
The queryConfigEnabled option was defined in defaults.js but was missing from the type-cast mappings. This meant it would not be properly type-cast when provided via query string or other string-based configuration sources. Fixes swagger-api#10744
5cd85a9 to
3558046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
queryConfigEnabledconfiguration option is defined insrc/core/config/defaults.js(line 66) with a default value offalse, but it was missing from the type-cast mappings insrc/core/config/type-cast/mappings.js.This means when
queryConfigEnabledwas provided via a string-based configuration source (e.g., query string), it would not be properly type-cast from a string to a boolean.Motivation and Context
Fixes #10744
Every other boolean config option in
defaults.jshas a corresponding entry inmappings.js. This was the only one missing.How Has This Been Tested?
defaults.jsagainstmappings.jsto verifyqueryConfigEnabledwas the only missing entrypersistAuthorization,tryItOutEnabled, etc.Screenshots (if appropriate):
N/A
Checklist
My PR contains...
src/is unmodified: changes to documentation, CI, metadata, etc.)package.json)My changes...
Documentation
Automated tests