Skip to content

fix(config): add missing queryConfigEnabled to type-cast mappings#10838

Open
yogeshwaran-c wants to merge 1 commit into
swagger-api:masterfrom
yogeshwaran-c:fix/add-missing-query-config-enabled-mapping
Open

fix(config): add missing queryConfigEnabled to type-cast mappings#10838
yogeshwaran-c wants to merge 1 commit into
swagger-api:masterfrom
yogeshwaran-c:fix/add-missing-query-config-enabled-mapping

Conversation

@yogeshwaran-c
Copy link
Copy Markdown

Description

The queryConfigEnabled configuration option is defined in src/core/config/defaults.js (line 66) with a default value of false, but it was missing from the type-cast mappings in src/core/config/type-cast/mappings.js.

This means when queryConfigEnabled was provided via a string-based configuration source (e.g., query string), it would not be properly type-cast from a string to a boolean.

Motivation and Context

Fixes #10744

Every other boolean config option in defaults.js has a corresponding entry in mappings.js. This was the only one missing.

How Has This Been Tested?

  • Compared all keys in defaults.js against mappings.js to verify queryConfigEnabled was the only missing entry
  • The mapping follows the exact same pattern as other boolean options like persistAuthorization, tryItOutEnabled, etc.

Screenshots (if appropriate):

N/A

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

The queryConfigEnabled option was defined in defaults.js but was
missing from the type-cast mappings. This meant it would not be
properly type-cast when provided via query string or other string-based
configuration sources.

Fixes swagger-api#10744
@yogeshwaran-c yogeshwaran-c force-pushed the fix/add-missing-query-config-enabled-mapping branch from 5cd85a9 to 3558046 Compare April 20, 2026 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

queryConfigEnabled is missing in src/core/config/type-cast/mappings.js

1 participant