feat: raise exception on non-2xx responses#659
Open
llimllib wants to merge 1 commit intoswar:masterfrom
Open
Conversation
It can be difficult to diagnose issues happening inside the library when it doesn't throw exceptions on exceptional responses. Use the raise_for_status method of requests to throw on non-2xx responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can be difficult to diagnose issues happening inside the library when it doesn't throw exceptions on exceptional responses. Use the
raise_for_statusmethod (docs) of requests to throw on 4xx and 5xx responsesAlso add a test for this behavior