Introduce HTTP/3 configuration#98
Open
aryan-25 wants to merge 4 commits into
Open
Conversation
gjcairo
requested changes
Jul 15, 2026
| /// `SETTINGS_MAX_FIELD_SECTION_SIZE`. | ||
| public var maximumFieldSectionSize: UInt64? | ||
|
|
||
| /// The default configuration. |
Collaborator
There was a problem hiding this comment.
I'm thinking we should perhaps move the comments about default values to here instead of having them at the property level, since they're really set at this point. This applies to all types.
Collaborator
There was a problem hiding this comment.
Thanks. With "all types" I meant other files as well, since we have this pattern elsewhere too. Would you mind making that change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
swift-nio-quicandswift-nio-http3have recently been announced, paving the way for HTTP/3 support inNIOHTTPServer.This PR introduces HTTP/3 configuration types as a first step towards HTTP/3 support.
Modifications:
Introduced a new
HTTP3type underNIOHTTPServerConfigurationcontaining three sub-components, namelyQUICConfiguration,ProtocolConfiguration, andConnectionSettings. These types wrap over the correspondingNIOQUICandNIOHTTP3types.Added
swift-nio-quic,swift-nio-quic-helpers, andswift-nio-http3dependencies.Result:
HTTP/3 configuration types are now defined.