[SwiftSyntaxCodeActions] Move SwiftRefactor code actions in from swift-syntax

[25harsh]

Moved SyntaxRefactoringProvider types mentioned in #2639 out of swift-syntax and intoSources/SwiftSyntaxCodeActions/.
Made access specifier changes and dependency changes.

Companion PR #3345

Notes:

1. Removed compiler(>=6) checks

2. Ported helpers from Sources/SwiftRefactor/SyntaxUtils.swift to Sources/SwiftSyntaxCodeActions/SyntaxRefactoringCodeActionProvider.swift

3. Test cases are yet to be moved.
   RemoveSeparatorsFromIntegerLiteral, RemoveRedundantParentheses andConvertStoredPropertyToComputed need coverage. (follow-on PRs)

4. Helpers moved DeclModifierRemover & IntegerLiteralUtilities

[ahoppen]

Thanks for the PR, @25harsh. I have two requests:

• Could you ensure that each file has a trailing newline and that they pass the swift-format check as described in CONTRIBUTING.md?
• Could you also migrate the tests to SourceKit-LSP. If they need some adjustment, that’s fine. I just don’t want to add the refactoring actions here without test coverage.

[25harsh]

@ahoppen all changes are done, overloaded assertRefactor for SyntaxRefactoringProvider that accepts some SyntaxProtocol for input and expected to avoid ambiguity

[ahoppen]

Thank you. This looks good to me, just one request: Could you create a separate SwiftSyntaxCodeActionsTests target for these new tests? We might want to move more of the existing code action tests to that target in a follow-up PR but I think it would be good to at least not inflate the current SourceKitLSPTests target further.

Also: Could you make sure that all test tests file and with Tests.swift to match the existing naming convention (and yes, I realize that they weren’t suffixed with Tests in swift-syntax but would be a good clean-up step now)

[25harsh]

@ahoppen all changes done, created new target SwiftSyntaxCodeActionsTests also i moved assertRefactor overload from Tests/SourceKitLSPTests/SyntaxRefactorTests.swift (added in last commit) to Tests/SwiftSyntaxCodeActionsTests/RefactorTestUtils.swift (similar name as swift-syntax)

[ahoppen]

Perfect 👌🏽 Thank you.

[ahoppen]

@swift-ci Please test

[ahoppen]

@swift-ci Please test Windows

[25harsh]

@ahoppen tests are failing due to ambiguity, this removal pr swift-syntax #3345 needs to be merged first

[rintaro]

swiftlang/swift-syntax#3345
@swift-ci Please test

[25harsh]

rebased with main (Sources/SwiftSyntaxCodeActions/CMakeLists.txt conflicted)

[ahoppen]

swiftlang/swift-syntax#3345
@swift-ci Please test

[ahoppen]

swiftlang/swift-syntax#3345
@swift-ci Please test macOS

[ahoppen]

swiftlang/swift-syntax#3345
@swift-ci Please test Windows

[25harsh]

Hey @ahoppen @rintaro, I noticed Windows CI errors related to @unknown default cases just pushed a commit adding #if RESILIENT_LIBRARIES

Note: for idealGroupSize in IntegerLiteralUtilities.swift I'm returning 3 since radix also falls back to .decimal https://github.com/swiftlang/swift-syntax/blob/d42bdde1ac20c3890639939b9bc9f3e390c7bf32/Sources/SwiftSyntax/Convenience.swift#L105

[ahoppen]

swiftlang/swift-syntax#3345
@swift-ci Please test

[ahoppen]

swiftlang/swift-syntax#3345

@swift-ci Please test Windows

[ahoppen]

swiftlang/swift-syntax#3345

@swift-ci Please test Windows