Detect and add a fix-it for using : instead of -> in a function#3276
Draft
j-f1 wants to merge 4 commits into
Draft
Detect and add a fix-it for using : instead of -> in a function#3276j-f1 wants to merge 4 commits into
j-f1 wants to merge 4 commits into
Conversation
j-f1
requested review from
ahoppen,
hamishknight,
hborla and
rintaro
as code owners
This comment was marked as outdated.
This comment was marked as outdated.
j-f1
force-pushed
the
jed/colon-to-arrow
branch
from
d566fa0 to
c1fcd35
Compare
rintaro
reviewed
Feb 18, 2026
rintaro
left a comment
rintaro
left a comment
Member
There was a problem hiding this comment.
Thanks! This is a very nice diagnostic that was missing in the new parser.
This comment was marked as outdated.
This comment was marked as outdated.
j-f1
force-pushed
the
jed/colon-to-arrow
branch
from
d901c1e to
1de154f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidentally do this quite regularly when changing a computed property to a method. This change adds a fix-it (including adding a space before the inserted
->) to make it a little easier to fix.