Skip to content

[6.4][Tests] Prevent inlining of a test function#3355

Merged
rintaro merged 1 commit into
swiftlang:release/6.4.xfrom
rintaro:6.4-workaround-rdar178757853
Jun 5, 2026
Merged

[6.4][Tests] Prevent inlining of a test function#3355
rintaro merged 1 commit into
swiftlang:release/6.4.xfrom
rintaro:6.4-workaround-rdar178757853

Conversation

@rintaro

@rintaro rintaro commented Jun 4, 2026

Copy link
Copy Markdown
Member

Cherry-pick #3354 into release/6.4

  • Explanation: Workaround for an inliner issue where a test function is mistakingly inlined into the test runner object file, causing linker error (missing symbols). To workaround that, add non-trivial test assertions.
  • Scope: Unit tests
  • Risk: Low. This is test only changes.
  • Issues: workaround for rdar://178757853
  • Testing: Passes the test suite
  • Reviewer: Hamish Knight (@hamishknight)

@rintaro rintaro requested a review from a team as a code owner June 4, 2026 21:25
@rintaro

rintaro commented Jun 4, 2026

Copy link
Copy Markdown
Member Author

@swift-ci Please test

Add non-trivial test assertions

Workaround for swiftlang/swift#88199

(cherry picked from commit 3488a84)
@rintaro rintaro force-pushed the 6.4-workaround-rdar178757853 branch from 24ac6ce to b8ffd33 Compare June 5, 2026 02:08
@rintaro

rintaro commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@swift-ci Please test

@rintaro

rintaro commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

@swift-ci Please test Windows

@rintaro rintaro merged commit b90056d into swiftlang:release/6.4.x Jun 5, 2026
37 of 38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants