Predicate Caching Impl - #268
Open
kurasaiteja wants to merge 5 commits into
Open
Conversation
Adds Watch{File,Env,Time} events on a non_exhaustive enum plus SDK emitter and consumer parser.
Unions Watch events into a set with a CacheTtl and captures mtime+size / env-value fingerprints.
at <cache_dir>/predicates/<sha256(workspace)>.json with schema-version invalidation.
Thin wrappers that emit WatchEnv/WatchFile before delegating to std, so predicates cache correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the predicate-caching RFD (#262). Custom predicates now emit
Watch{File,Env,Time}JSONL events on stdout. Symposium caches their exit-coderesult in~/.symposium/cache/predicates/<workspace-hash>.jsonand skipsre-evaluation until a watched file, env var, or TTL becomes stale.
Three granular events on a
#[non_exhaustive]CustomPredicateEventenumWatchFile(PathBuf)result depends on this file'smtime + size.WatchEnv(String)result depends on this env var's current value.WatchTime(u64)result becomes stale after this many milliseconds.WatchTime(0)disables caching.Exit status still determines pass/fail. Events only control cache lifetime.
Cache layout
Per-workspace cache file at
<SymposiumDirs::cache_dir>/predicates/<sha256(canonical workspace_root)>.jsonI think isolating by workspace prevents two projects on the same machine that emit the same predicate string from stepping on each other's cached answers. Schema version tag invalidates on Symposium upgrade.
Note
path_existsis one stat, env is one hashmap lookup and the cache check would cost the same as just running them, so caching them doesn't buy anything. If it's useful to route them through the cache for observability, happy to add.Disclosure questions
AI disclosure.
Questions for reviewers.