Conversation
Agree, this UX could be improved. Probably requires more sheets for setting the mnemonic + passphrase |
|
There are still some small changes from design v60 changelog. I'll implement them in other PR |
This change is inconsistent in that it requires a PIN when navigating to "Back up your wallet" from settings but tapping the suggestion card or the backup prompt does not. As mention in iOS PR, this flow is not specified to be gated by auth. If you think this makes sense please leave a comment in Figma so we can take the time to think it through properly with design team instead of appending UX changes on your own. Sticking to this process also helps keeping the two implementation at par. |
|
Removed backup gating in 02f9d5b Screen_recording_20260330_070222.webm |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Fixed 408ec89 pin-dismiss.webm |
Done b11aeba Very nice effect! support-nav-color.webm |
pwltr
left a comment
There was a problem hiding this comment.
LGTM, functionality/design ACK, did not review code
There was a problem hiding this comment.
Review Pass 3
Retested all 27 commits since Pass 2 (CHANGES_REQUESTED). Phil already approved design/functionality.
Previous Change Requests — Verified
- BUG1 (PIN+BIO nav loop): Fixed — PIN auth gate removed from Reset & Restore. Back nav works normally with PIN+BIO and PIN-only.
- BUG2 (Mnemonic without PIN): Resolved — backup gating removed per Phil's feedback (not in Figma, inconsistent with other entry points). Acceptable.
- Trailing commas on modifier call sites: Fixed. Some stragglers remain — not a blocker.
- showSystemUi preview setup: Fixed.
- Language.kt resId: Fixed.
- AGENTS.md modifier rules: Updated and clear.
New Changes — Tested
- PIN auto-navigation: Enable/disable PIN auto-pops back to Security tab. Change PIN doesn't auto-pop (nit, not a blocker).
- Forgot PIN back button: Visible, dismisses sheet correctly.
- PIN dots alignment: Properly centered in Change PIN flow.
- Lightning Connections empty state: Onboarding UI shows correctly, "Get Started" navigates properly, channel list shows when channels exist.
- Support screen brand color: Orange diagonal covers full bottom area including nav bar inset. No visual glitches.
- Share icon: Correct (16x16, orange tint).
- Electrum host prefix: Clean display without protocol prefix.
- String/translation fixes: Capitalization correct, PIN error message updated.
Nits (non-blocking)
- Some trailing commas after modifier args still not cleaned up.
- Change PIN flow doesn't auto-navigate back after success (same as RN app behavior).
- PIN + BIO: tap Biometrics then "Use PIN Code" — PIN numpad doesn't show. Not a regression (RN app did the same). Ideally we'd hide the button or actually show the numpad.
Remarks (out of scope for this PR)
- Inconsistency: mnemonic screen is shown without auth, but Recovery mode requires it. I still believe we should gate mnemonic viewing with auth, but this is out of scope for this redesign.
- Recovery Screen requires PIN to wipe wallet — should align the approach or at least ack why it's inconsistent.
- Still need to test PIN (± BIO) (± QuickPay) for pay flows — separate from this PR, because I have an issue building bitkit-ios right now.
LGTM, code ACK.

Implements v60 design for settings, matching iOS PR #490.
Description
This PR:
SettingsIconcomposable for consistent icon rendering across settings screensFigma:
Preview
tab-navigation.webm
support.webm
general-tab.mp4
advanced-tab.webm
security-sheet.webm
QA Notes
1. Tab navigation
2. General tab
3. Security tab
4. Advanced tab
5. PIN management
6. Support screen & drawer
7. Widgets settings
8. Sub-screens