fix: avoid msat truncation when paying invoices with built-in amounts#512
Open
ben-kaufman wants to merge 3 commits intomasterfrom
Open
fix: avoid msat truncation when paying invoices with built-in amounts#512ben-kaufman wants to merge 3 commits intomasterfrom
ben-kaufman wants to merge 3 commits intomasterfrom
Conversation
Bump bitkit-core to v0.1.56 which rounds up sub-satoshi invoice amounts. Additionally, stop overriding the amount for invoices that already have one. Pass sats: nil so LDK uses the invoice's native msat precision instead of our truncated sats value converted back to msat. Only pass sats for zero-amount invoices where the user specifies the amount. Closes #511
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment has been minimized.
This comment has been minimized.
3 tasks
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sats: nilso LDK uses the invoice's native msat precision instead of our truncated sats value converted back to msatsatsfor zero-amount invoices where the user specifies the amountTest plan
lnd.addInvoice({ valueMsat })using amounts222538,222222,500500msatDepends on synonymdev/bitkit-core#85
Closes #511
🤖 Generated with Claude Code