feat(e2e): Layer 1 Kind-based E2E — CRDs, operator health, webhooks, CRUD, metrics

Replace scaffold-generated e2e suite with a Helm-based Kind test that
installs imp-crds + imp via Helm, then asserts all six CRDs are present,
the operator pod reaches Running, the admission webhook rejects invalid
ImpVMs, CRUD round-trip succeeds, and /metrics returns 200.

Add e2e-kind CI job (helm/kind-action) alongside the existing Talos e2e
job so Kind tests run on ubuntu-latest without a self-hosted runner.

Author: syscod3

.github/workflows/ci.yml

@@ -105,3 +105,24 @@ jobs:
       - name: Cleanup
         if: always()
         run: talosctl cluster destroy --name imp-e2e
+
+  e2e-kind:
+    name: E2E (Kind)
+    runs-on: ${{ vars.E2E_RUNNER_LABEL || 'ubuntu-latest' }}
+    needs: [lint, build]
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: actions/setup-go@v5
+        with:
+          go-version-file: go.mod
+
+      - uses: helm/kind-action@v1
+        with:
+          cluster_name: imp-e2e
+
+      - name: Install Helm
+        uses: azure/setup-helm@v4
+
+      - name: Run E2E tests
+        run: go test -tags e2e ./test/e2e/... -v -timeout 15m

test/e2e/e2e_suite_test.go

@@ -20,8 +20,6 @@ limitations under the License.
 package e2e
 
 import (
-	"fmt"
-	"os"
 	"os/exec"
 	"testing"
 
@@ -31,74 +29,50 @@ import (
 	"github.com/syscode-labs/imp/test/utils"
 )
 
-var (
-	// managerImage is the manager image to be built and loaded for testing.
-	managerImage = "imp-operator:dev"
-	// shouldCleanupCertManager tracks whether CertManager was installed by this suite.
-	shouldCleanupCertManager = false
+const (
+	namespace      = "imp-system"
+	helmRelease    = "imp"
+	helmCRDRelease = "imp-crds"
 )
 
-// TestE2E runs the e2e test suite to validate the solution in an isolated environment.
-// The default setup requires Kind and CertManager.
-//
-// To skip CertManager installation, set: CERT_MANAGER_INSTALL_SKIP=true
-func TestE2E(t *testing.T) {
-	RegisterFailHandler(Fail)
-	_, _ = fmt.Fprintf(GinkgoWriter, "Starting imp e2e test suite\n")
-	RunSpecs(t, "e2e suite")
-}
-
 var _ = BeforeSuite(func() {
-	By("building the manager image")
-	cmd := exec.Command("make", "docker-build", fmt.Sprintf("IMG=%s", managerImage)) //nolint:gosec
-	_, err := utils.Run(cmd)
-	ExpectWithOffset(1, err).NotTo(HaveOccurred(), "Failed to build the manager image")
-
-	By("loading the manager image on Kind")
-	err = utils.LoadImageToKindClusterWithName(managerImage)
-	ExpectWithOffset(1, err).NotTo(HaveOccurred(), "Failed to load the manager image into Kind")
-
-	// CertManager is only needed for webhooks. Skip unless CERT_MANAGER_INSTALL_SKIP=false.
-	if os.Getenv("CERT_MANAGER_INSTALL_SKIP") != "false" {
-		_, _ = fmt.Fprintf(GinkgoWriter, "Skipping CertManager (no webhooks in this build)\n")
-		return
-	}
-	setupCertManager()
+	By("creating namespace")
+	nsCmd := exec.Command("kubectl", "create", "ns", namespace)
+	_, _ = utils.Run(nsCmd) // ignore if already exists
+
+	By("installing cert-manager")
+	Expect(utils.InstallCertManager()).To(Succeed(), "helm install cert-manager failed")
+
+	By("installing imp-crds chart")
+	crdsCmd := exec.Command("helm", "install", helmCRDRelease, "charts/imp-crds",
+		"--namespace", namespace, "--wait", "--create-namespace")
+	_, err := utils.Run(crdsCmd)
+	Expect(err).NotTo(HaveOccurred(), "helm install imp-crds failed")
+
+	By("installing imp chart")
+	impCmd := exec.Command("helm", "install", helmRelease, "charts/imp",
+		"--namespace", namespace,
+		"--set", "metrics.serviceMonitor.enabled=false",
+		"--set", "metrics.podMonitor.enabled=false",
+		"--wait", "--timeout", "2m")
+	_, err = utils.Run(impCmd)
+	Expect(err).NotTo(HaveOccurred(), "helm install imp failed")
 })
 
 var _ = AfterSuite(func() {
-	teardownCertManager()
-})
+	By("uninstalling imp chart")
+	unimpCmd := exec.Command("helm", "uninstall", helmRelease, "--namespace", namespace)
+	_, _ = utils.Run(unimpCmd)
 
-// setupCertManager installs CertManager if needed for webhook tests.
-// Skips installation if CERT_MANAGER_INSTALL_SKIP=true or if already present.
-func setupCertManager() {
-	if os.Getenv("CERT_MANAGER_INSTALL_SKIP") == "true" {
-		_, _ = fmt.Fprintf(GinkgoWriter, "Skipping CertManager installation (CERT_MANAGER_INSTALL_SKIP=true)\n")
-		return
-	}
-
-	By("checking if CertManager is already installed")
-	if utils.IsCertManagerCRDsInstalled() {
-		_, _ = fmt.Fprintf(GinkgoWriter, "CertManager is already installed. Skipping installation.\n")
-		return
-	}
-
-	// Mark for cleanup before installation to handle interruptions and partial installs.
-	shouldCleanupCertManager = true
-
-	By("installing CertManager")
-	Expect(utils.InstallCertManager()).To(Succeed(), "Failed to install CertManager")
-}
+	By("uninstalling imp-crds chart")
+	uncrdsCmd := exec.Command("helm", "uninstall", helmCRDRelease, "--namespace", namespace)
+	_, _ = utils.Run(uncrdsCmd)
 
-// teardownCertManager uninstalls CertManager if it was installed by setupCertManager.
-// This ensures we only remove what we installed.
-func teardownCertManager() {
-	if !shouldCleanupCertManager {
-		_, _ = fmt.Fprintf(GinkgoWriter, "Skipping CertManager cleanup (not installed by this suite)\n")
-		return
-	}
-
-	By("uninstalling CertManager")
+	By("uninstalling cert-manager")
 	utils.UninstallCertManager()
+})
+
+func TestE2E(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "Imp E2E Suite")
 }