Skip to content
This repository was archived by the owner on Feb 6, 2026. It is now read-only.

fix: re-anble onfailure marker for luminork tests#7684

Merged
johnrwatson merged 2 commits into
mainfrom
fix/luminork-not-paging
Nov 4, 2025
Merged

fix: re-anble onfailure marker for luminork tests#7684
johnrwatson merged 2 commits into
mainfrom
fix/luminork-not-paging

Conversation

@johnrwatson

@johnrwatson johnrwatson commented Nov 4, 2025

Copy link
Copy Markdown
Contributor

Re-enabling as the flake comment is no longer relevant

Also add a max of 5s to resolve the schema details in the failing test.


See test here for new output https://github.com/systeminit/si/actions/runs/19080282395/job/54506753708

ref:

Schemas API - List and Find Schemas ...
------- post-test output -------
Loaded variables from .env file
Configuration sources:
- API URL: Environment
- Auth Token: Environment
- Workspace ID: Environment
- Timeout: .env file
Created change set with ID: 01K9851XTRQ1878VHV7JPNJT5S
Found schema with ID: 01J1QXEJC12EEBZ00H4T15YHNQ and name: Docker Image
Testing find schema by name: Docker Image
Got 202 response, retrying in 1000ms (attempt 1/5)
Got 202 response, retrying in 1000ms (attempt 2/5)
Got 202 response, retrying in 1000ms (attempt 3/5)
Successfully retrieved schema variant with ID: 01K9851YGXN59HX0FGBHMMCD24

@github-actions

github-actions Bot commented Nov 4, 2025

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@github-actions github-actions Bot added the A-ci Area: CI configuration files and scripts label Nov 4, 2025
nickgerace
nickgerace previously approved these changes Nov 4, 2025
} else {
break; // Exit on unexpected status codes
}
} while (getVariantResponse.status === 202 && attempts < maxAttempts);

@nickgerace nickgerace Nov 4, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, TIL about this syntax with do and while combined.

@fnichol fnichol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

@johnrwatson johnrwatson added this pull request to the merge queue Nov 4, 2025
Merged via the queue into main with commit 83c41b2 Nov 4, 2025
22 checks passed
@johnrwatson johnrwatson deleted the fix/luminork-not-paging branch November 4, 2025 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

A-ci Area: CI configuration files and scripts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants