Merge pull request #128 from tSQLt-org/TransactionFree20211219

Transaction free20211219

Author: mbt1

Experiments/Debugging tSQLt.tdf

@@ -66,6 +66,12 @@
           <AssociatedConnUserName />
           <FullPath>LIKE4000.sql</FullPath>
         </FileNode>
+        <FileNode Name="MSSQL Defect Try-Catch Invalidates Transaction.sql">
+          <AssociatedConnectionMoniker />
+          <AssociatedConnSrvName />
+          <AssociatedConnUserName />
+          <FullPath>MSSQL Defect Try-Catch Invalidates Transaction.sql</FullPath>
+        </FileNode>
         <FileNode Name="NameResolutionResearch.sql">
           <AssociatedConnectionMoniker />
           <AssociatedConnSrvName />

Experiments/Experiments.ssmssqlproj

@@ -0,0 +1,20 @@
+PRINT 'No TRY...CATCH:';
+EXEC ('BEGIN TRAN');
+SELECT XACT_STATE() AS [XACT_STATE()],@@TRANCOUNT AS [@@TRANCOUNT];
+GO
+IF(XACT_STATE()<>0)ROLLBACK;
+GO
+
+
+
+GO
+PRINT 'In TRY...CATCH:';
+BEGIN TRY
+EXEC ('BEGIN TRAN');
+END TRY
+BEGIN CATCH
+END CATCH;
+SELECT XACT_STATE() AS [XACT_STATE()],@@TRANCOUNT AS [@@TRANCOUNT];
+GO
+IF(XACT_STATE()<>0)ROLLBACK;
+GO

Experiments/MSSQL Defect Try-Catch Invalidates Transaction.sql

@@ -81,6 +81,7 @@ BEGIN
         BEGIN
           EXEC @SetUp;
         END;
+
         EXEC (@TestExecutionCmd);
 
         IF(EXISTS(SELECT 1 FROM #ExpectException WHERE ExpectException = 1))

Experiments/SM query.sql …eriments/SM query - read trace table.sqlExperiments/SM query.sql renamed to Experiments/SM query - read trace table.sql Experiments/SM query.sql renamed to Experiments/SM query - read trace table.sql

@@ -2441,33 +2441,42 @@ GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
 
----[@tSQLt:SkipTest]('TODO: need to review handling of unexpected changes to the tSQLt transaction')
 CREATE PROCEDURE Run_Methods_Tests.[test produces meaningful error when pre and post transactions counts don't match]
 AS
 BEGIN
-  EXEC tSQLt.NewTestClass 'MyInnerTests'
+  EXEC tSQLt.NewTestClass 'MyInnerTestsA'
+  EXEC('CREATE PROCEDURE MyInnerTestsA.[test should execute outside of transaction] AS BEGIN TRAN;');
+
+  EXEC tSQLt.ExpectException @ExpectedMessage = 'SOMETHING RATHER', @ExpectedSeverity = NULL, @ExpectedState = NULL;
+  EXEC tSQLt.Run 'MyInnerTestsA.[test should execute outside of transaction]';
+
+END;
+GO
+/*-----------------------------------------------------------------------------------------------*/
+GO
+
+--[@tSQLt:SkipTest]('TODO: need to review handling of unexpected changes to the tSQLt transaction for NoTransaction tests')
+CREATE PROCEDURE Run_Methods_Tests.[test produces meaningful error when pre and post transactions counts don't match in NoTransaction test]
+AS
+BEGIN
+  EXEC tSQLt.NewTestClass 'MyInnerTestsB'
   EXEC('
 --[@'+'tSQLt:NoTransaction](DEFAULT)
-CREATE PROCEDURE MyInnerTests.[test should execute outside of transaction] AS BEGIN TRAN;SELECT * FROM fn_dblog(NULL,NULL) WHERE [Transaction ID] = (SELECT LL.[Transaction ID] FROM fn_dblog(NULL,NULL) LL JOIN sys.dm_tran_current_transaction AS DTCT ON DTCT.transaction_id = LL.[Xact ID]);
+CREATE PROCEDURE MyInnerTestsB.[test should execute outside of transaction] AS BEGIN TRAN;SELECT * FROM fn_dblog(NULL,NULL) WHERE [Transaction ID] = (SELECT LL.[Transaction ID] FROM fn_dblog(NULL,NULL) LL JOIN sys.dm_tran_current_transaction AS DTCT ON DTCT.transaction_id = LL.[Xact ID]);
   ');
 
   EXEC tSQLt.ExpectException @ExpectedMessage = 'SOMETHING RATHER', @ExpectedSeverity = NULL, @ExpectedState = NULL;
 
   BEGIN TRY
-  EXEC tSQLt.Run 'MyInnerTests.[test should execute outside of transaction]';
+    EXEC tSQLt.Run 'MyInnerTestsB.[test should execute outside of transaction]';
   END TRY
   BEGIN CATCH
-  SELECT * FROM fn_dblog(NULL,NULL) WHERE [Transaction ID] = (SELECT LL.[Transaction ID] FROM fn_dblog(NULL,NULL) LL JOIN sys.dm_tran_current_transaction AS DTCT ON DTCT.transaction_id = LL.[Xact ID]);
+    SELECT * FROM fn_dblog(NULL,NULL) WHERE [Transaction ID] = (SELECT LL.[Transaction ID] FROM fn_dblog(NULL,NULL) LL JOIN sys.dm_tran_current_transaction AS DTCT ON DTCT.transaction_id = LL.[Xact ID]);
   END CATCH;
-
-
 END;
 GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
-EXEC tSQLt.Run 'Run_Methods_Tests.[test produces meaningful error when pre and post transactions counts don''t match]';
-GO
-SELECT * FROM tSQLt.TestResult;
 /*--
   Transaction Tests