Trying to debug an issue with transactions when we open a transaction within an inner no-transaction test <-- we have no issues when the inner test is not a no-transaction test and we should include this test in the test class.

Author: lizbaron

Source/Run_Methods.sql

@@ -209,7 +209,6 @@ BEGIN
           SET @Result = 'Error';
         END;
     END CATCH;  
-
     IF (@NoTransactionFlag = 1)
     BEGIN
       SET @CleanUpProcedureExecutionCmd = (
@@ -241,7 +240,6 @@ BEGIN
              @TestResult = @Result OUT,
              @TestMsg = @Msg OUT
     END;
-
     IF(@TransactionStartedFlag = 1)
     BEGIN
       COMMIT;
@@ -326,7 +324,8 @@ BEGIN
           @TranName,
           @Result OUT,
           @Msg OUT,
-          @TestEndTime OUT
+          @TestEndTime OUT;
+
       END;
       ELSE
       BEGIN
@@ -351,7 +350,6 @@ BEGIN
       SET @Msg2 = @TestName + ' failed: (' + @Result + ') ' + @Msg;
       EXEC tSQLt.Private_Print @Message = @Msg2, @Severity = 0;
     END;
-
     IF EXISTS(SELECT 1 FROM tSQLt.TestResult WHERE Id = @TestResultId)
     BEGIN
         UPDATE tSQLt.TestResult SET
@@ -370,8 +368,6 @@ BEGIN
                'TestResult entry is missing; Original outcome: ' + @Result + ', ' + @Msg;
     END;    
 
-
-
     IF(@Verbose = 1)
     BEGIN
       SET @VerboseMsg = 'tSQLt.Run '''+@TestName+'''; --Finished';

Tests/Run_Methods_Tests.class.sql

@@ -2448,13 +2448,26 @@ BEGIN
   EXEC tSQLt.NewTestClass 'MyInnerTests'
   EXEC('
 --[@'+'tSQLt:NoTransaction](DEFAULT)
-CREATE PROCEDURE MyInnerTests.[test should execute outside of transaction] AS BEGIN TRAN;
+CREATE PROCEDURE MyInnerTests.[test should execute outside of transaction] AS BEGIN TRAN;SELECT * FROM fn_dblog(NULL,NULL) WHERE [Transaction ID] = (SELECT LL.[Transaction ID] FROM fn_dblog(NULL,NULL) LL JOIN sys.dm_tran_current_transaction AS DTCT ON DTCT.transaction_id = LL.[Xact ID]);
   ');
 
   EXEC tSQLt.ExpectException @ExpectedMessage = 'SOMETHING RATHER', @ExpectedSeverity = NULL, @ExpectedState = NULL;
 
+  BEGIN TRY
   EXEC tSQLt.Run 'MyInnerTests.[test should execute outside of transaction]';
+  END TRY
+  BEGIN CATCH
+  SELECT * FROM fn_dblog(NULL,NULL) WHERE [Transaction ID] = (SELECT LL.[Transaction ID] FROM fn_dblog(NULL,NULL) LL JOIN sys.dm_tran_current_transaction AS DTCT ON DTCT.transaction_id = LL.[Xact ID]);
+  END CATCH;
 
+
+END;
+GO
+/*-----------------------------------------------------------------------------------------------*/
+GO
+EXEC tSQLt.Run 'Run_Methods_Tests.[test produces meaningful error when pre and post transactions counts don''t match]';
+GO
+SELECT * FROM tSQLt.TestResult;
 /*--
   Transaction Tests
   
@@ -2464,11 +2477,6 @@ CREATE PROCEDURE MyInnerTests.[test should execute outside of transaction] AS BE
   - what should we do if the original transaction was rolled back and a new one was created?
   - what should we do if the original transaction was committed and a new one was created?
   - we still need to save the TranName as something somewhere.
-  - review existing tests for transactions
+  - do existing tests already cover some of the scenarios described above?
 
 --*/
-
-END;
-GO
-/*-----------------------------------------------------------------------------------------------*/
-GO