fix(cookies): use constant-time comparison for signature verification#3
Merged
Conversation
Replace naive string comparison (===) with @std/crypto timingSafeEqual() to prevent timing attacks. The previous implementation returned early on the first mismatched character, allowing attackers to measure response times and incrementally guess correct signatures byte-by-byte. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
===) with@std/cryptotimingSafeEqual()to prevent timing attacksSecurity Impact
Vulnerability: Timing attack on cookie signature verification
Severity: Medium - requires network-level timing measurements, but feasible with statistical analysis
Fix: Use constant-time comparison that takes the same amount of time regardless of where the mismatch occurs
Changes
Test plan
🤖 Generated with Claude Code