You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The .github actions should be generic since this is a template, but they were specific to Tableland's core team (code owners, secrets, etc.). E.g., someone cloning and try to use this repo would be setting up things they don't need. This removes most of these actions and keeps generic ones.
Details
Removed unneeded .github workflows and moved the useful ones for this use case to a .github.example folder.
How it was tested
N/A
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
@awmuncy i'm assuming that since i removed GH actions, the lint/test workflows aren't running, which is blocking the merge. i'm guessing that would require an admin to merge it or something like that?
@awmuncy i'm assuming that since i removed GH actions, the lint/test workflows aren't running, which is blocking the merge. i'm guessing that would require an admin to merge it or something like that?
Oh, yes, you're correct. I've run into this issue before when update github actions. I'm not an admin. @joewagner can you take a look?
@awmuncy i'm assuming that since i removed GH actions, the lint/test workflows aren't running, which is blocking the merge. i'm guessing that would require an admin to merge it or something like that?
Oh, yes, you're correct. I've run into this issue before when update github actions. I'm not an admin. @joewagner can you take a look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
.githubactions should be generic since this is a template, but they were specific to Tableland's core team (code owners, secrets, etc.). E.g., someone cloning and try to use this repo would be setting up things they don't need. This removes most of these actions and keeps generic ones.Details
Removed unneeded
.githubworkflows and moved the useful ones for this use case to a.github.examplefolder.How it was tested
N/A
Checklist: