Skip to content

feat: make .github actions a generic example#102

Open
dtbuchholz wants to merge 1 commit into
mainfrom
dtb/fix-github-workflow
Open

feat: make .github actions a generic example#102
dtbuchholz wants to merge 1 commit into
mainfrom
dtb/fix-github-workflow

Conversation

@dtbuchholz
Copy link
Copy Markdown
Contributor

Summary

The .github actions should be generic since this is a template, but they were specific to Tableland's core team (code owners, secrets, etc.). E.g., someone cloning and try to use this repo would be setting up things they don't need. This removes most of these actions and keeps generic ones.

Details

Removed unneeded .github workflows and moved the useful ones for this use case to a .github.example folder.

How it was tested

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dtbuchholz
Copy link
Copy Markdown
Contributor Author

@awmuncy i'm assuming that since i removed GH actions, the lint/test workflows aren't running, which is blocking the merge. i'm guessing that would require an admin to merge it or something like that?

@awmuncy
Copy link
Copy Markdown

awmuncy commented Jul 19, 2023

@awmuncy i'm assuming that since i removed GH actions, the lint/test workflows aren't running, which is blocking the merge. i'm guessing that would require an admin to merge it or something like that?

Oh, yes, you're correct. I've run into this issue before when update github actions. I'm not an admin. @joewagner can you take a look?

@joewagner
Copy link
Copy Markdown
Contributor

@awmuncy i'm assuming that since i removed GH actions, the lint/test workflows aren't running, which is blocking the merge. i'm guessing that would require an admin to merge it or something like that?

Oh, yes, you're correct. I've run into this issue before when update github actions. I'm not an admin. @joewagner can you take a look?

I'm not an admin either. Maybe @carsonfarmer is?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants