Conversation
rathboma
requested changes
Jun 5, 2026
rathboma
left a comment
rathboma
left a comment
Collaborator
There was a problem hiding this comment.
No bug fixes without tests plz
| @@ -10,7 +10,7 @@ export default function(cell, formatterParams, onRendered){ | |||
| var after = !!formatterParams.symbolAfter; | |||
| var precision = typeof formatterParams.precision !== "undefined" ? formatterParams.precision : 2; | |||
|
|
|||
| if(isNaN(floatVal)){ | |||
| if(Number.isNaN(floatVal)){ | |||
rathboma
approved these changes
Jun 9, 2026
pull Bot
pushed a commit
to TheRakeshPurohit/tabulator
that referenced
this pull request
Jun 9, 2026
…bulator-tables#4895 Adds unit tests validating the isNaN -> Number()/Number.isNaN fixes that prevent 'Cannot convert a BigInt value to a number' errors: - Sort.findSorter / ColumnManager.calculateSorterFromValue auto-detect a number sorter for BigInt column values (PR tabulator-tables#4894) - star formatter renders correctly for BigInt cell values (PR tabulator-tables#4895) Each test throws without its corresponding fix and passes with it. Mocks are avoided; tests drive a real Tabulator instance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.