connect: fix etcd connection for non admin users#106
Merged
Conversation
sssciel
force-pushed
the
g.rybakov/tntp-7780-fix-admin-for-connect
branch
6 times, most recently
from
31d318a to
7622464
Compare
bigbes
approved these changes
May 27, 2026
Mockird31
approved these changes
May 28, 2026
NewEtcdStorage checked the cluster status through the Maintenance.Status function, which requires root permissions. Replace it with MemberList (serializable), which is open to any authenticated user and avoids a raft round-trip, so the connection probe no longer crashes for non-admin credentials. Part of TNTP-7780
sssciel
force-pushed
the
g.rybakov/tntp-7780-fix-admin-for-connect
branch
from
7622464 to
361d1cc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewEtcdStorage checked the cluster status through the Status function, which requires root permissions, see
etcd-io/etcd#21666. Therefore, an additional check was added to ensure that the connection does not crash in the absence of root permissions.
Part of TNTP-7780