Skip to content

Add bundled OpenSSL backend for uv Python#39

Open
river-walras wants to merge 1 commit into
tarasko:masterfrom
river-walras:bundled-openssl-uv-python
Open

Add bundled OpenSSL backend for uv Python#39
river-walras wants to merge 1 commit into
tarasko:masterfrom
river-walras:bundled-openssl-uv-python

Conversation

@river-walras

Copy link
Copy Markdown

Summary

  • add an opt-in/auto-detected bundled OpenSSL backend for Python builds that cannot expose a dynamic libssl, such as uv python-build-standalone
  • add aiofastnet.SSLContext to record unrecoverable SSLContext configuration for replay onto aiofastnet's own SSL_CTX
  • add server-context preflight, bundled ALPN handling, verify flag copying, cache invalidation, and bundled-backend test coverage

Validation

  • UV_CACHE_DIR=/tmp/uv-cache uv run pytest tests/test_ssl_object.py -q
  • UV_CACHE_DIR=/tmp/uv-cache uv run ruff check .
  • git diff --check

@river-walras river-walras marked this pull request as ready for review June 28, 2026 15:38
@tarasko

tarasko commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Thank you for the PR. I need to carefully review it.

One thing that I noticed, instead of downloading, I'd like to have a git submodule link to openssl inside of vendor/ folder and build it there.

@codecov-commenter

codecov-commenter commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 18.42105% with 186 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.22%. Comparing base (6d47711) to head (f443dc3).

Files with missing lines Patch % Lines
aiofastnet/ssl_object.pyx 14.64% 169 Missing ⚠️
aiofastnet/_sslcontext.py 35.00% 13 Missing ⚠️
aiofastnet/openssl_compat.py 55.55% 3 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   92.29%   86.22%   -6.07%     
==========================================
  Files          12       13       +1     
  Lines        2426     2636     +210     
  Branches       15       15              
==========================================
+ Hits         2239     2273      +34     
- Misses        183      359     +176     
  Partials        4        4              
Flag Coverage Δ
Linux 83.72% <18.42%> (-5.97%) ⬇️
Windows 79.54% <18.42%> (-5.72%) ⬇️
macOS 81.09% <18.42%> (-5.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Jun 29, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 34 untouched benchmarks


Comparing river-walras:bundled-openssl-uv-python (f443dc3) with master (6d47711)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants