fix(build): use bootstrap's validated Python; drop fragile re-detection#25
Merged
Conversation
…tection bootstrap.ps1 validates Python via `Get-Command py`, then shelled out to build.bat which threw that away and re-detected with `where py/python/python3`. That second probe fails on setups the PowerShell session resolves fine (e.g. the 3.14 Install Manager / app-execution aliases), so the build aborted with "No Python interpreter found" even though Python was clearly present. - bootstrap.ps1: export HYPERWALL_PY=py before calling build.bat. - build.bat: honor HYPERWALL_PY before its own `where` probes. - bootstrap.ps1: fix stale "HYPERWALL 8.2" banner -> v10 (matches __version__). Verified: bootstrap-path build (HYPERWALL_PY=py) runs PyInstaller through to dist\hyperwall.exe and the repo-root copy. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bootstrap.ps1validates Python viaGet-Command py, then shelled out tobuild.bat, which discarded that and re-detected withwhere py/python/python3. That second probe misses installs the PowerShell session resolves fine (3.14 Install Manager / app-execution aliases), so the build aborted with "No Python interpreter found" despite Python being present.Changes
bootstrap.ps1: exportHYPERWALL_PY=pybefore invokingbuild.bat.build.bat: honorHYPERWALL_PYbefore its ownwhereprobes.bootstrap.ps1: staleHYPERWALL 8.2banner →v10(matches__version__).Verified
Ran the bootstrap-path build (
HYPERWALL_PY=py); PyInstaller completes throughdist\hyperwall.exeand the repo-root copy (exit 0).🤖 Generated with Claude Code