-
Notifications
You must be signed in to change notification settings - Fork 17
Add PolicyId output to Get-TeamViewerGroup function #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c0c15a9
44c0b50
86bf8a0
11ca6b3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -52,6 +52,8 @@ function Get-TeamViewerGroup { | |
| Write-Output ($response | ConvertTo-TeamViewerGroup) | ||
| } | ||
| else { | ||
| Write-Output ($response.groups | ConvertTo-TeamViewerGroup) | ||
| $groups = @($response.groups | ConvertTo-TeamViewerGroup) | ||
| $groups | ForEach-Object { $_.PSObject.Properties.Remove('PolicyId') } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. question: why don't we want the PolicyId field when requesting multiple groups?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well yes, this is very individual. Personally, I don't need this information in the all group output.
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Since the WebApi endpoint exposes it, I don't see a reason for not including it in the Powershell's response :) |
||
| Write-Output $groups | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -3,7 +3,7 @@ | |||||
| RootModule = 'TeamViewerPS.psm1' | ||||||
|
|
||||||
| # Version number of this module. | ||||||
| ModuleVersion = '2.5.1' | ||||||
| ModuleVersion = '2.5.2' | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Patch version is for documentation changes and other such fixes. Here, we are doing much more than that, hence a minor version bump is in order.
Suggested change
|
||||||
|
|
||||||
| # Supported PSEditions. | ||||||
| # CompatiblePSEditions = @() | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that you have to request a release for this from @ChristianJ-TV or @stefanhubertus when it is merged.